Page MenuHomePhabricator

[keyserver] Don't send empty ID cleanup query in notifs code
ClosedPublic

Authored by ashoat on Thu, Sep 14, 6:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 25, 4:44 AM
Unknown Object (File)
Fri, Sep 15, 1:18 PM
Subscribers
None

Details

Summary

I introduced a regression in D9175. The issue is detailed in this Linear comment thread, but basically there's a possibility of dbIDs being non-empty when it's checked, but empty by the time the query is run.

The core issue here is that we're not waiting for the code that dequeues from dbIDs to complete before checking (and running) the cleanup query. This diff makes sure we wait until deliveryPromises are all resolved before checking and running the cleanup query.

Test Plan

I was able to repro the issue in my local environment before this diff (see Linear comment thread). After this diff, the issue no longer repro'd

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable