Page MenuHomePhabricator

[lib] Get rid of innerNotificationTexts
ClosedPublic

Authored by ashoat on Sep 25 2023, 5:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 11:01 PM
Unknown Object (File)
Thu, May 2, 11:00 PM
Unknown Object (File)
Thu, May 2, 10:12 PM
Unknown Object (File)
Thu, May 2, 8:56 PM
Unknown Object (File)
Sat, Apr 13, 5:53 AM
Unknown Object (File)
Mar 31 2024, 8:13 AM
Unknown Object (File)
Mar 31 2024, 8:13 AM
Unknown Object (File)
Mar 31 2024, 8:13 AM
Subscribers

Details

Summary

When @tomek first started using message specs for notifs in D644, he introduced this parameter because it was needed for sidebar sources.

However, at a later point we realized that we had notifs disabled for sidebar sources. In D6870 I replaced that code with an invariant.

We no longer need this innerNotificationTexts, and it presents an ongoing maintenance cost (most recently noticed in D9249). As such, I'd like to remove it. We can always bring it back later if we need it.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable