Page MenuHomePhabricator

[lib] Get rid of innerNotificationTexts
ClosedPublic

Authored by ashoat on Sep 25 2023, 5:41 AM.
Tags
None
Referenced Files
F3619682: D9278.id31399.diff
Wed, Jan 1, 9:58 PM
F3619681: D9278.id31387.diff
Wed, Jan 1, 9:58 PM
F3619641: D9278.id.diff
Wed, Jan 1, 9:57 PM
F3619602: D9278.diff
Wed, Jan 1, 9:50 PM
Unknown Object (File)
Sat, Dec 28, 3:56 AM
Unknown Object (File)
Thu, Dec 26, 7:15 PM
Unknown Object (File)
Thu, Dec 26, 7:14 PM
Unknown Object (File)
Thu, Dec 26, 7:14 PM
Subscribers

Details

Summary

When @tomek first started using message specs for notifs in D644, he introduced this parameter because it was needed for sidebar sources.

However, at a later point we realized that we had notifs disabled for sidebar sources. In D6870 I replaced that code with an invariant.

We no longer need this innerNotificationTexts, and it presents an ongoing maintenance cost (most recently noticed in D9249). As such, I'd like to remove it. We can always bring it back later if we need it.

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable