Page MenuHomePhabricator

[lib] Add invariant to SidebarSource notificationTexts
ClosedPublic

Authored by ashoat on Feb 23 2023, 1:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 3:34 PM
Unknown Object (File)
Oct 27 2024, 1:54 PM
Unknown Object (File)
Oct 18 2024, 5:17 AM
Unknown Object (File)
Oct 18 2024, 5:17 AM
Unknown Object (File)
Oct 18 2024, 5:16 AM
Unknown Object (File)
Oct 18 2024, 5:16 AM
Unknown Object (File)
Sep 27 2024, 5:56 PM
Unknown Object (File)
Sep 27 2024, 5:56 PM
Subscribers

Details

Summary

While we do indicate SidebarSource generates notifs in generatesNotifs, it should always be collapsed, and should never appear as the most recent message for a given collapse key (since CreateSidebar is created at the same time and always is considered "newer").

To make sure that notificationTexts is never called for SidebarSource, I'm adding this invariant here.

Depends on D6869

Test Plan

Made sure this invariant never gets triggered in a variety of sidebar creation scenarios

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable