Page MenuHomePhabricator

[lib] Collapse CreateSidebar and SidebarSource notifs together
ClosedPublic

Authored by ashoat on Feb 23 2023, 1:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 27 2024, 9:31 PM
Unknown Object (File)
Feb 22 2024, 12:38 PM
Unknown Object (File)
Feb 21 2024, 9:08 AM
Unknown Object (File)
Feb 21 2024, 9:08 AM
Unknown Object (File)
Feb 21 2024, 9:08 AM
Unknown Object (File)
Feb 21 2024, 9:08 AM
Unknown Object (File)
Feb 20 2024, 6:24 AM
Unknown Object (File)
Feb 18 2024, 12:57 AM
Subscribers

Details

Summary

Before this diff, SidebarSource did not generate any notifs, and CreateSidebar did.

After this diff, technically SidebarSource generates a notif... but not really. Since SidebarSource and CreateSidebar get collapsed into each other, and CreateSidebar is the more recent message, AND the two messages are always generated together on the keyserver... the result is that they only ever generate one notif for the both of them.

The only reason for this is that I want to have access to the SidebarSource message in CreateSidebar's notificationTexts function so that I can check it for @-mentions.

Depends on D6868

Test Plan

In combination with the rest of the stack, I confirmed that a sidebar started in response to a text message that @-mentions somebody will result in the @-mentioned user receiving a custom notif that ends with "that tagged you"

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 23 2023, 1:37 PM
Harbormaster failed remote builds in B16850: Diff 23029!
This revision is now accepted and ready to land.Feb 24 2023, 11:50 PM