[keyserver] Make sure we fetch username of all notif recipients
ClosedPublic
Actions

Authored by ashoat on Feb 23 2023, 1:16 PM.

Details

Reviewers

atul
ginsu

Commits

rCOMMfea1dddf0ca5: [keyserver] Make sure we fetch username of all notif recipients

Summary

This honestly probably isn't necessary, since we already fetch usernames for all thread members, and you shouldn't be receiving a notif unless you're a thread member.

But it doesn't hurt to add this to the set here, and there might be a scenario in the future where somebody is able to receive a notif without being a thread member.

Depends on D6870

Test Plan

There's not much to test here, to be honest... I actually think this diff is a no-op in the current scenario. It's more about future-proofing. We should always fetch the recipient's username

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 23 2023, 1:16 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 23 2023, 1:16 PM

ashoat added a child revision: D6872: [keyserver] Update notif prepare functions to take bag of params.Feb 23 2023, 1:16 PM

Harbormaster completed remote builds in B16852: Diff 23031.Feb 23 2023, 1:38 PM

ashoat requested review of this revision.Feb 23 2023, 1:39 PM

atul accepted this revision.Feb 24 2023, 11:50 PM

This revision is now accepted and ready to land.Feb 24 2023, 11:50 PM

Closed by commit rCOMMfea1dddf0ca5: [keyserver] Make sure we fetch username of all notif recipients (authored by ashoat). · Explain WhyFeb 27 2023, 3:56 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMfea1dddf0ca5: [keyserver] Make sure we fetch username of all notif recipients.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

send.js

1 line

Diff 23198

View Options

keyserver/src/push/send.js

Show All 20 Lines	function SidebarItem(props: Props): React.Node {
} = threadInfo;		} = threadInfo;

const onClick = useOnClickThread(threadInfo);		const onClick = useOnClickThread(threadInfo);

const unreadCls = classNames(css.sidebarTitle, { [css.unread]: unread });		const unreadCls = classNames(css.sidebarTitle, { [css.unread]: unread });

return (		return (
<>		<>
<SWMansionIcon icon="right-angle-arrow" size={28} />		<SWMansionIcon icon="right-angle-arrow" color="transparent" size={28} />
<div className={css.spacer} />		<div className={css.spacer} />
<a className={css.threadButtonSidebar} onClick={onClick}>		<a className={css.threadButtonSidebar} onClick={onClick}>
<div className={css.threadRow}>		<div className={css.threadRow}>
<div className={unreadCls}>{threadInfo.uiName}</div>		<div className={unreadCls}>{threadInfo.uiName}</div>
</div>		</div>
</a>		</a>
</>		</>
);		);
}		}

export default SidebarItem;		export default SidebarItem;

[keyserver] Make sure we fetch username of all notif recipientsClosedPublicActions