Page MenuHomePhabricator

[keyserver] Make sure we fetch username of all notif recipients
ClosedPublic

Authored by ashoat on Feb 23 2023, 1:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 31, 8:13 AM
Unknown Object (File)
Sun, Mar 31, 8:13 AM
Unknown Object (File)
Sun, Mar 31, 8:13 AM
Unknown Object (File)
Sun, Mar 31, 8:06 AM
Unknown Object (File)
Mar 6 2024, 4:48 AM
Unknown Object (File)
Mar 4 2024, 10:12 AM
Unknown Object (File)
Feb 21 2024, 2:06 PM
Unknown Object (File)
Feb 21 2024, 2:06 PM
Subscribers

Details

Summary

This honestly probably isn't necessary, since we already fetch usernames for all thread members, and you shouldn't be receiving a notif unless you're a thread member.

But it doesn't hurt to add this to the set here, and there might be a scenario in the future where somebody is able to receive a notif without being a thread member.

Depends on D6870

Test Plan

There's not much to test here, to be honest... I actually think this diff is a no-op in the current scenario. It's more about future-proofing. We should always fetch the recipient's username

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable