Page MenuHomePhabricator

[keyserver] Make sure we fetch username of all notif recipients
ClosedPublic

Authored by ashoat on Feb 23 2023, 1:16 PM.
Tags
None
Referenced Files
F1737800: D6871.diff
Sat, May 11, 3:52 AM
F1737305: D6871.id23198.diff
Fri, May 10, 11:34 PM
F1737304: D6871.id23031.diff
Fri, May 10, 11:34 PM
F1737303: D6871.id.diff
Fri, May 10, 11:34 PM
F1737302: D6871.diff
Fri, May 10, 11:34 PM
Unknown Object (File)
Thu, May 2, 11:02 PM
Unknown Object (File)
Thu, May 2, 11:01 PM
Unknown Object (File)
Thu, May 2, 10:13 PM
Subscribers

Details

Summary

This honestly probably isn't necessary, since we already fetch usernames for all thread members, and you shouldn't be receiving a notif unless you're a thread member.

But it doesn't hurt to add this to the set here, and there might be a scenario in the future where somebody is able to receive a notif without being a thread member.

Depends on D6870

Test Plan

There's not much to test here, to be honest... I actually think this diff is a no-op in the current scenario. It's more about future-proofing. We should always fetch the recipient's username

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable