Page MenuHomePhabricator

[keyserver][lib] Pass notifTargetUserInfo to notificationTexts
ClosedPublic

Authored by ashoat on Feb 23 2023, 1:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 7 2024, 4:03 PM
Unknown Object (File)
Oct 27 2024, 1:54 PM
Unknown Object (File)
Oct 18 2024, 5:43 PM
Unknown Object (File)
Oct 18 2024, 5:43 PM
Unknown Object (File)
Oct 18 2024, 5:17 AM
Unknown Object (File)
Oct 18 2024, 5:17 AM
Unknown Object (File)
Sep 28 2024, 3:58 PM
Unknown Object (File)
Sep 27 2024, 5:56 PM
Subscribers

Details

Summary

Today, each MessageSpec's notificationTexts actually has no awareness of the user that is being sent the notif.

Some message types (eg. relationship, reaction) use terms like "you", but don't need to check the userID since the notif is only ever generated for one user. For example, since we know only that reactions only send notifs to the original message author, we can say "your message" in the notif without checking who is receiving the notif.

Other message types that you might expect would need awareness of the notif recipient (join thread, leave thread, add users, remove users) don't actually generate notifs.

In a following diff, I'm going to introduce a notif where we will need this data. In particular, we're going to add "and tagged you" to some notifs when the recipient user was tagged, and to do that we need to know about the recipient user.

Depends on D6872

Test Plan

In combination with the rest of the stack, I confirmed that a sidebar started in response to a text message that @-mentions somebody will result in the @-mentioned user receiving a custom notif that ends with "that tagged you"

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable