Page MenuHomePhabricator
Differential D6872

[keyserver] Update notif prepare functions to take bag of params
ClosedPublic
Actions

Authored by ashoat on Feb 23 2023, 1:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 2:54 AM
Unknown Object (File)
Sat, Apr 5, 2:18 AM
Unknown Object (File)
Wed, Apr 2, 3:50 PM
Unknown Object (File)
Wed, Apr 2, 3:50 PM
Unknown Object (File)
Wed, Apr 2, 11:08 AM
Unknown Object (File)
Mar 17 2025, 7:21 PM
Unknown Object (File)
Mar 17 2025, 4:47 AM
Unknown Object (File)
Mar 17 2025, 4:46 AM
View All Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM9a53f51d3c24: [keyserver] Update notif prepare functions to take bag of params
Summary

These functions take a long list of inputs. I'm about to add one more, so I figured it would be best to refactor them to take an object of params instead of a list.

Depends on D6871

Test Plan

Flow. Also in combination with the rest of the stack, I confirmed that a sidebar started in response to a text message that @-mentions somebody will result in the @-mentioned user receiving a custom notif that ends with "that tagged you"

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
73 lines

Diff 23199

View Options

keyserver/src/push/send.js

Show First 20 Lines • Show All 67 Lines • ▼ Show 20 Lines - [Debugging](./nix_web_workflows.md#debugging)
- [React Developer Tools](./nix_web_workflows.md#react-developer-tools) - [React Developer Tools](./nix_web_workflows.md#react-developer-tools)
- [Redux Developer Tools](./nix_web_workflows.md#redux-developer-tools) - [Redux Developer Tools](./nix_web_workflows.md#redux-developer-tools)
- [Debugging JavaScript](./nix_web_workflows.md#debugging-javascript) - [Debugging JavaScript](./nix_web_workflows.md#debugging-javascript)
- [Mobile workflows](./nix_mobile_workflows.md#mobile-workflows) - [Mobile workflows](./nix_mobile_workflows.md#mobile-workflows)
- [Running mobile app on iOS Simulator](./nix_mobile_workflows.md#running-mobile-app-on-ios-simulator) - [Running mobile app on iOS Simulator](./nix_mobile_workflows.md#running-mobile-app-on-ios-simulator)
- [Running mobile app on Android Emulator](./nix_mobile_workflows.md#running-mobile-app-on-android-emulator) - [Running mobile app on Android Emulator](./nix_mobile_workflows.md#running-mobile-app-on-android-emulator)
- [Running mobile app on physical iOS devices](./nix_mobile_workflows.md#running-mobile-app-on-physical-ios-devices) - [Running mobile app on physical iOS devices](./nix_mobile_workflows.md#running-mobile-app-on-physical-ios-devices)
- [Shared workflows](./nix_shared_workflows.md#shared-workflows) - [Shared workflows](./nix_shared_workflows.md#shared-workflows)
- [Inspect database with TablePlus](./nix_shared_workflows.md#inspect-database-with-tableplus)
- [Codegen](./nix_shared_workflows.md#codegen) - [Codegen](./nix_shared_workflows.md#codegen)
- [Codegen for JSI](./nix_shared_workflows.md#codegen-for-jsi) - [Codegen for JSI](./nix_shared_workflows.md#codegen-for-jsi)
- [Codegen for gRPC](./nix_shared_workflows.md#codegen-for-grpc) - [Codegen for gRPC](./nix_shared_workflows.md#codegen-for-grpc)
- [Working with Phabricator](./nix_shared_workflows.md#working-with-phabricator) - [Working with Phabricator](./nix_shared_workflows.md#working-with-phabricator)
- [Creating a new diff](./nix_shared_workflows.md#creating-a-new-diff) - [Creating a new diff](./nix_shared_workflows.md#creating-a-new-diff)
- [Updating a diff](./nix_shared_workflows.md#updating-a-diff) - [Updating a diff](./nix_shared_workflows.md#updating-a-diff)
- [Working with a stack](./nix_shared_workflows.md#working-with-a-stack) - [Working with a stack](./nix_shared_workflows.md#working-with-a-stack)
- [Committing a diff](./nix_shared_workflows.md#committing-a-diff) - [Committing a diff](./nix_shared_workflows.md#committing-a-diff)
- [Final notes](./nix_shared_workflows.md#final-notes) - [Final notes](./nix_shared_workflows.md#final-notes)
## How Nix introduces dependencies to a development environment ## How Nix introduces dependencies to a development environment
Nix installs packages in the Nix store at package-specific paths (e.g. `/nix/store/x7kdiasp...-clang/bin/clang`). When you run `nix develop`, Nix sets environment variables such as `PATH` to expose the binary dependencies to your shell. This model can be extended through shell hooks to support other build toolchains such as `pkg-config`, `cmake`, and many other language specific package managers by simply adding the respective toolchain to `nativeBuildInputs`. Nix installs packages in the Nix store at package-specific paths (e.g. `/nix/store/x7kdiasp...-clang/bin/clang`). When you run `nix develop`, Nix sets environment variables such as `PATH` to expose the binary dependencies to your shell. This model can be extended through shell hooks to support other build toolchains such as `pkg-config`, `cmake`, and many other language specific package managers by simply adding the respective toolchain to `nativeBuildInputs`.