Page MenuHomePhabricator

[keyserver] Make sure we fetch username of all notif recipients
ClosedPublic

Authored by ashoat on Feb 23 2023, 1:16 PM.
Tags
None
Referenced Files
F3513162: D6871.diff
Sat, Dec 21, 11:00 PM
Unknown Object (File)
Oct 27 2024, 1:54 PM
Unknown Object (File)
Oct 18 2024, 5:43 PM
Unknown Object (File)
Oct 18 2024, 5:17 AM
Unknown Object (File)
Oct 18 2024, 5:17 AM
Unknown Object (File)
Oct 18 2024, 5:17 AM
Unknown Object (File)
Sep 27 2024, 5:56 PM
Unknown Object (File)
Sep 27 2024, 5:56 PM
Subscribers

Details

Summary

This honestly probably isn't necessary, since we already fetch usernames for all thread members, and you shouldn't be receiving a notif unless you're a thread member.

But it doesn't hurt to add this to the set here, and there might be a scenario in the future where somebody is able to receive a notif without being a thread member.

Depends on D6870

Test Plan

There's not much to test here, to be honest... I actually think this diff is a no-op in the current scenario. It's more about future-proofing. We should always fetch the recipient's username

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable