Page MenuHomePhabricator

[native] Add a C++ MessageSpec for SidebarSource
ClosedPublic

Authored by ashoat on Mar 16 2023, 1:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 18, 1:48 AM
Unknown Object (File)
Sat, Feb 17, 11:11 PM
Unknown Object (File)
Sat, Feb 17, 9:19 PM
Unknown Object (File)
Sat, Feb 17, 6:59 PM
Unknown Object (File)
Tue, Feb 6, 6:10 AM
Unknown Object (File)
Tue, Feb 6, 6:10 AM
Unknown Object (File)
Mon, Feb 5, 12:33 AM
Unknown Object (File)
Jan 13 2024, 8:34 PM
Subscribers

Details

Summary

In D6869, I updated SidebarSourceMessageSpec.generatesNotifs so that it returned pushTypes.NOTIF. While SidebarSourceMessageSpec.notificationTexts should never be called, this still made it so SidebarSource messages could be included as the second item in notif payloads' messageInfos, since they get collapsed into the CreateSidebar.

As a result of being included in the notif payloads, SidebarSource is now getting processed by NSE, but since there is a missing C++ MessageSpec for it, we end up persisting an empty content to SQLite.

Test Plan

I was able to repro the "content must be defined" error before this diff by creating a sidebar that auto-added a test user. The test user would get the payload with SidebarSource, which would trigger the error. After this diff, the error no longer repros

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable