[keyserver] Test impact of improving encoding on Ashoat's ThreadStore
ClosedPublic
Actions

Authored by ashoat on Sep 29 2023, 1:28 PM.

Details

Reviewers

atul
tomek

Commits

rCOMM744748a96b9a: [keyserver] Test impact of improving encoding on Ashoat's ThreadStore

Summary

This diff stack introduces a script that tests various different approaches to reducing the size of the ThreadStore. We may or may not land it... the goal is just to get some numbers.

Depends on D9336

Test Plan

Run the script:

after improving encoding, Ashoat's ThreadStore is 11123335 bytes large

Corresponds to 10.61 MiB, which is a reduction of 84.63%.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Sep 29 2023, 1:28 PM

ashoat added a child revision: D9338: [keyserver] Test impact of introduction of isAdminRole on Ashoat's ThreadStore.Sep 29 2023, 1:30 PM

Harbormaster completed remote builds in B22931: Diff 31570.Sep 29 2023, 1:49 PM

ashoat requested review of this revision.Sep 29 2023, 1:49 PM

atul accepted this revision.Sep 29 2023, 7:34 PM

This revision is now accepted and ready to land.Sep 29 2023, 7:34 PM

Closed by commit rCOMM744748a96b9a: [keyserver] Test impact of improving encoding on Ashoat's ThreadStore (authored by ashoat). · Explain WhySep 30 2023, 5:27 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM744748a96b9a: [keyserver] Test impact of improving encoding on Ashoat's ThreadStore.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

scripts/

test-threadstore-reductions.js

138 lines

Diff 31581

View Options

keyserver/src/scripts/test-threadstore-reductions.js

	Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines

	const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>			const urlPrefixSelector: (state: AppState) => ?string = (state: AppState) =>
	state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;			state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.urlPrefix;

	const connectionSelector: (state: AppState) => ?ConnectionInfo = (			const connectionSelector: (state: AppState) => ?ConnectionInfo = (
	state: AppState,			state: AppState,
	) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;			) => state.keyserverStore.keyserverInfos[ashoatKeyserverID]?.connection;

	const lastCommunicatedPlatformDetailsSelector: (			const baseLastCommunicatedPlatformDetailsSelector: (
	state: AppState,			keyserverID: string,
	) => ?PlatformDetails = (state: AppState) =>			) => (state: AppState) => ?PlatformDetails = keyserverID => (state: AppState) =>
	state.keyserverStore.keyserverInfos[ashoatKeyserverID]			state.keyserverStore.keyserverInfos[keyserverID]
	?.lastCommunicatedPlatformDetails;			?.lastCommunicatedPlatformDetails;

				const lastCommunicatedPlatformDetailsSelector: (
				keyserverID: string,
				) => (state: AppState) => ?PlatformDetails = _memoize(
				baseLastCommunicatedPlatformDetailsSelector,
				);

	const selectedKeyserversSelector: (			const selectedKeyserversSelector: (
	state: AppState,			state: AppState,
	) => $ReadOnlyArray<SelectedKeyserverInfo> = createSelector(			) => $ReadOnlyArray<SelectedKeyserverInfo> = createSelector(
	(state: AppState) => state.keyserverStore.keyserverInfos,			(state: AppState) => state.keyserverStore.keyserverInfos,
	(state: AppState) => state.userStore.userInfos,			(state: AppState) => state.userStore.userInfos,
	(keyserverInfos: KeyserverInfos, userInfos: UserInfos) => {			(keyserverInfos: KeyserverInfos, userInfos: UserInfos) => {
	const result = [];			const result = [];

	▲ Show 20 Lines • Show All 52 Lines • Show Last 20 Lines

[keyserver] Test impact of improving encoding on Ashoat's ThreadStoreClosedPublicActions