Page MenuHomePhabricator
Differential D9947

[web] Update `sendTextMessage` to accept `MinimallyEncodedThreadInfo`s
ClosedPublic
Actions

Authored by atul on Nov 21 2023, 12:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 4:47 PM
Unknown Object (File)
Mon, Mar 17, 4:47 PM
Unknown Object (File)
Mon, Mar 17, 4:45 PM
Unknown Object (File)
Mon, Mar 17, 4:22 PM
Unknown Object (File)
Feb 20 2025, 7:22 PM
Unknown Object (File)
Feb 12 2025, 11:05 PM
Unknown Object (File)
Feb 12 2025, 11:05 PM
Unknown Object (File)
Feb 12 2025, 11:04 PM
View All 72 Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
Commits
rCOMMa4ac0b27156c: [web] Update `sendTextMessage` to accept `MinimallyEncodedThreadInfo`s
Summary

Attempt to resolve Flow issue flagged by @ashoat here: https://phab.comm.dev/D9907#inline-61984

Test Plan
  1. I patched the latest diff in your stack
  2. Observed the flow issue in web/input-input-state-container

ff1630.png (466×2 px, 144 KB)

  1. Made the same change as D9947 and ensured that the flow issue disappeared.

eb1098.png (270×1 px, 45 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
web/
input/
4 lines

Diff 33531

View Options

web/input/input-state-container.react.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import Animated from 'react-native-reanimated'; import Animated from 'react-native-reanimated';
import { localIDPrefix } from 'lib/shared/message-utils.js'; import { useNextLocalID } from 'lib/shared/message-utils.js';
import { import {
useViewerAlreadySelectedMessageReactions, useViewerAlreadySelectedMessageReactions,
useCanCreateReactionFromMessage, useCanCreateReactionFromMessage,
} from 'lib/shared/reaction-utils.js'; } from 'lib/shared/reaction-utils.js';
import { TooltipInlineEngagement } from './inline-engagement.react.js'; import { TooltipInlineEngagement } from './inline-engagement.react.js';
import { InnerRobotextMessage } from './inner-robotext-message.react.js'; import { InnerRobotextMessage } from './inner-robotext-message.react.js';
import { useSendReaction } from './reaction-message-utils.js'; import { useSendReaction } from './reaction-message-utils.js';
▲ Show 20 Lines • Show All 66 Lines • ▼ Show 20 Lines return (
progress={progress} progress={progress}
windowWidth={windowWidth} windowWidth={windowWidth}
initialCoordinates={initialCoordinates} initialCoordinates={initialCoordinates}
/> />
); );
}, [initialCoordinates, isOpeningSidebar, item, progress, windowWidth]); }, [initialCoordinates, isOpeningSidebar, item, progress, windowWidth]);
const { messageInfo, threadInfo, reactions } = item; const { messageInfo, threadInfo, reactions } = item;
const nextLocalID = useSelector(state => state.nextLocalID); const localID = useNextLocalID();
const localID = `${localIDPrefix}${nextLocalID}`;
const canCreateReactionFromMessage = useCanCreateReactionFromMessage( const canCreateReactionFromMessage = useCanCreateReactionFromMessage(
threadInfo, threadInfo,
messageInfo, messageInfo,
); );
const sendReaction = useSendReaction( const sendReaction = useSendReaction(
messageInfo.id, messageInfo.id,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines