Paths

Table of Contentst

Differential D9947

[web] Update `sendTextMessage` to accept `MinimallyEncodedThreadInfo`s
ClosedPublic
Actions

Authored by atul on Nov 21 2023, 12:50 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 1, 11:36 PM

	Unknown Object (File)
	Sat, Oct 26, 1:01 AM

	Unknown Object (File)
	Sat, Oct 26, 1:01 AM

	Unknown Object (File)
	Sat, Oct 26, 1:01 AM

	Unknown Object (File)
	Sat, Oct 26, 12:55 AM

	Unknown Object (File)
	Oct 12 2024, 4:44 PM

	Unknown Object (File)
	Sep 28 2024, 2:52 PM

	Unknown Object (File)
	Sep 19 2024, 1:16 PM

View All 51 Files

Subscribers

Details

Reviewers

Commits

rCOMMa4ac0b27156c: [web] Update `sendTextMessage` to accept `MinimallyEncodedThreadInfo`s

Summary

Attempt to resolve Flow issue flagged by @ashoat here: https://phab.comm.dev/D9907#inline-61984

Test Plan

I patched the latest diff in your stack
Observed the flow issue in web/input-input-state-container

Made the same change as D9947 and ensured that the flow issue disappeared.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Nov 21 2023, 12:50 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 21 2023, 12:50 PM

atul published this revision for review.Nov 21 2023, 1:02 PM

atul mentioned this in D9907: [flow] Update `useResolvedThreadInfo` and fix subsequent `flow` issues.Nov 21 2023, 1:05 PM

atul edited the test plan for this revision. (Show Details)

atul attached a referenced file: F888234: eb1098.png. (Show Details)

atul attached a referenced file: F888233: ff1630.png. (Show Details)

Harbormaster completed remote builds in B24316: Diff 33472.Nov 21 2023, 1:20 PM

ashoat accepted this revision.Nov 21 2023, 1:34 PM

This revision is now accepted and ready to land.Nov 21 2023, 1:34 PM

Closed by commit rCOMMa4ac0b27156c: [web] Update `sendTextMessage` to accept `MinimallyEncodedThreadInfo`s (authored by atul). · Explain WhyNov 22 2023, 12:50 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMa4ac0b27156c: [web] Update `sendTextMessage` to accept `MinimallyEncodedThreadInfo`s.

Revision Contents
Changeset List

Path

Size

web/

input/

input-state-container.react.js

4 lines

Diff 33531

web/input/input-state-container.react.js

Loading...