[desktop] Add additional logging
ClosedPublic
Actions

Authored by michal on Nov 22 2023, 5:56 AM.

Details

Reviewers

ashoat
tomek
marcin

Commits

rCOMM763c72d5d880: [desktop] Add additional logging

Summary

Additional logging for investigation of ENG-5606. Types taken from electron docs.

Test Plan

Run a packaged app, went into Activity Monitor and killed process:

process "Comm Helper (Renderer)" -> Got "EVENT: render-process-gone. Reason: 'killed'. ExitCode: '9'."
process "Comm Helper (GPU)" -> Got "EVENT: child-process-gone. Process type: 'GPU'. Reason: 'killed'. ExitCode: '9'."

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Nov 22 2023, 5:56 AM

Can you adjust to make sure that all lines are no longer than 80 chars?

Harbormaster completed remote builds in B24327: Diff 33483.Nov 22 2023, 6:14 AM

michal requested review of this revision.Nov 22 2023, 6:14 AM

Fix line lengths

ashoat accepted this revision.Nov 22 2023, 6:17 AM

This revision is now accepted and ready to land.Nov 22 2023, 6:17 AM

Harbormaster completed remote builds in B24328: Diff 33484.Nov 22 2023, 6:35 AM

Closed by commit rCOMM763c72d5d880: [desktop] Add additional logging (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyNov 22 2023, 6:51 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM763c72d5d880: [desktop] Add additional logging.

Revision Contents
Changeset List

Path

Size

desktop/

flow-typed/

npm/

electron_v22.0.0.js

18 lines

src/

main.js

14 lines

Diff 33488

View Options

desktop/flow-typed/npm/electron_v22.0.0.js