Instead of setting it in one place, and then conditionally unsetting it later... we should probably just check the condition in the first place.
Details
Details
- I tested different values of defaultMaxMessageAge such that some threads would return fewer than defaultNumberPerThread, and some threads would return 0
- I tested threads that needed a fetchMostRecentMessages, and threads that needed multiple fetchMessagesBeforeCursor to get to the start
- I made sure all threads loaded all the way to the start of a thread if I kept scrolling
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- ashoat/startReached-bug
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| server/src/fetchers/message-fetchers.js | ||
|---|---|---|
| 316 ↗ | (On Diff #10313) |
This is probably no longer the case |
| server/src/fetchers/message-fetchers.js | ||
|---|---|---|
| 316 ↗ | (On Diff #10313) | I considered removing this, but then I realized that the code on line 345 technically can "unset" TRUNCATED. Not sure it's worth keeping this comment, though... it can "unset" any value, not just TRUNCATED. I'll consider removing it before landing |