Page MenuHomePhabricator
Differential D3431

[lib] [refactor] useToggleUnreadStatus hook, fix up deps array after move
ClosedPublic
Actions

Authored by • benschac on Mar 15 2022, 10:00 AM.
Tags
None
Referenced Files
F3356100: D3431.id10394.diff
Sat, Nov 23, 4:51 PM
F3355366: D3431.diff
Sat, Nov 23, 2:24 PM
Unknown Object (File)
Wed, Nov 13, 12:42 PM
Unknown Object (File)
Sun, Nov 10, 12:10 AM
Unknown Object (File)
Sun, Nov 10, 12:10 AM
Unknown Object (File)
Sun, Nov 10, 12:10 AM
Unknown Object (File)
Fri, Nov 8, 7:42 AM
Unknown Object (File)
Tue, Nov 5, 1:03 AM
View All Files
Subscribers
• adrian
ashoat
• karol

Details

Reviewers
tomek
atul
• jacek
Commits
rCOMM030b94fff148: [lib] [refactor] useToggleUnreadStatus hook, fix up deps array after move
Summary

follow up from comment in https://phabricator.ashoat.com/D3418 and Tomek's comment about dep values being incorrect.

Test Plan

test unread functionality in both web and native UI's. Unread status should work in both native and web.

Diff Detail

Repository
rCOMM Comm
Branch
new-update-hook
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• benschac created this revision.Mar 15 2022, 10:00 AM
Herald added subscribers: • karol, • adrian, ashoat. · View Herald TranscriptMar 15 2022, 10:00 AM
• benschac added a parent revision: D3419: [native] [refactor] use toggle unread hook.Mar 15 2022, 10:02 AM
Harbormaster completed remote builds in B7384: Diff 10394.Mar 15 2022, 10:05 AM
• benschac requested review of this revision.Mar 15 2022, 10:05 AM
tomek accepted this revision.Mar 16 2022, 7:12 AM
tomek added inline comments.
lib/hooks/toggle-unread-status.js
43–45

You can use a shorthand

This revision is now accepted and ready to land.Mar 16 2022, 7:12 AM
• benschac updated this revision to Diff 10480.Mar 17 2022, 10:39 AM

rebase

• benschac added inline comments.Mar 17 2022, 10:45 AM
lib/hooks/toggle-unread-status.js
43–45

optional was taken out.

Harbormaster completed remote builds in B7444: Diff 10480.Mar 17 2022, 10:45 AM
Closed by commit rCOMM030b94fff148: [lib] [refactor] useToggleUnreadStatus hook, fix up deps array after move (authored by • benschac). · Explain WhyMar 21 2022, 7:08 AM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM030b94fff148: [lib] [refactor] useToggleUnreadStatus hook, fix up deps array after move.

Revision Contents
Changeset List

PathSize
lib/
hooks/
9 lines

Diff 10394

View Options

lib/hooks/toggle-unread-status.js

Loading...