Page MenuHomePhabricator

[lib] [refactor] useToggleUnreadStatus hook, fix up deps array after move
ClosedPublic

Authored by benschac on Mar 15 2022, 10:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 7:56 PM
Unknown Object (File)
Sat, Nov 23, 5:13 PM
Unknown Object (File)
Sat, Nov 23, 4:51 PM
Unknown Object (File)
Sat, Nov 23, 2:24 PM
Unknown Object (File)
Wed, Nov 13, 12:42 PM
Unknown Object (File)
Sun, Nov 10, 12:10 AM
Unknown Object (File)
Sun, Nov 10, 12:10 AM
Unknown Object (File)
Sun, Nov 10, 12:10 AM

Details

Summary

follow up from comment in https://phabricator.ashoat.com/D3418 and Tomek's comment about dep values being incorrect.

Test Plan

test unread functionality in both web and native UI's. Unread status should work in both native and web.

Diff Detail

Repository
rCOMM Comm
Branch
new-update-hook
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek added inline comments.
lib/hooks/toggle-unread-status.js
43–45 ↗(On Diff #10394)

You can use a shorthand

This revision is now accepted and ready to land.Mar 16 2022, 7:12 AM
lib/hooks/toggle-unread-status.js
43–45 ↗(On Diff #10394)

optional was taken out.