Paths

Table of Contentst

[web] [fix] ENG-897 update icons svg json to remove blue pre-fill colors.
ClosedPublic
Actions

Authored by • benschac on Mar 18 2022, 6:48 AM.

Details

Reviewers

atul
• jacek
tomek
ashoat

Commits

rCOMM2674c50021d3: [web] [fix] ENG-897 update icons svg json to remove blue pre-fill colors.

Summary

https://linear.app/comm/issue/ENG-897/fix-icons-with-blue-fill

before:

Image 2022-03-18 at 9.43.49 AM.jpg (206×230 px, 4 KB)

after:

Image 2022-03-18 at 9.39.08 AM.jpg (184×220 px, 3 KB)

Image 2022-03-18 at 9.49.37 AM.jpg (1×3 px, 354 KB)

Test Plan

icons should render correctly with correct color

Diff Detail

Repository

rCOMM Comm

Branch

arcpatch-D3458_1

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Mar 18 2022, 6:48 AM

Herald added subscribers: • karol, • adrian, tomek, ashoat. · View Herald TranscriptMar 18 2022, 6:48 AM

• benschac edited the summary of this revision. (Show Details)Mar 18 2022, 6:49 AM

• benschac added reviewers: • jacek, tomek.

Harbormaster completed remote builds in B7476: Diff 10528.Mar 18 2022, 7:03 AM

• benschac requested review of this revision.Mar 18 2022, 7:03 AM

It fixes the problem

This revision is now accepted and ready to land.Mar 18 2022, 7:25 AM

Unacceptable diff name

This revision now requires changes to proceed.Mar 20 2022, 9:07 PM

In D3458#94127, @ashoat wrote:

Unacceptable diff name

That's fair. I should have updated and also chatted with you about it.

• benschac requested review of this revision.Mar 21 2022, 8:17 AM

• benschac retitled this revision from [web] [fix] ENG-897 to [web] [fix] ENG-897 update icons svg json to remove blue pre-fill colors..

Thanks!! Blindly accepting now (no idea how to review this selection.json file)

This revision is now accepted and ready to land.Mar 21 2022, 8:22 AM

Can you please redo this (https://github.com/CommE2E/comm/commit/66ec123390b9d1d49e9fc9ae7fa9067c47903251) change before landing?

add wrench

This revision was landed with ongoing or failed builds.Mar 21 2022, 11:54 AM

Closed by commit rCOMM2674c50021d3: [web] [fix] ENG-897 update icons svg json to remove blue pre-fill colors. (authored by • benschac). · Explain Why

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM2674c50021d3: [web] [fix] ENG-897 update icons svg json to remove blue pre-fill colors..

Harbormaster completed remote builds in B7510: Diff 10572.Mar 21 2022, 11:59 AM

Revision Contents
Changeset List

Path

Size

web/

icons/

selection.json

157 lines

Diff 10572

View Options

[web] [fix] ENG-897 update icons svg json to remove blue pre-fill colors.ClosedPublicActions