Page MenuHomePhabricator

[web] Move bulk of `LoginModal` to `LoginForm`
ClosedPublic

Authored by atul on Mar 22 2022, 3:12 PM.
Tags
None
Referenced Files
F2905671: D3491.id10618.diff
Sun, Oct 6, 7:27 AM
F2905463: D3491.diff
Sun, Oct 6, 5:47 AM
Unknown Object (File)
Fri, Oct 4, 1:38 PM
Unknown Object (File)
Fri, Oct 4, 1:38 PM
Unknown Object (File)
Fri, Oct 4, 1:38 PM
Unknown Object (File)
Fri, Oct 4, 1:38 PM
Unknown Object (File)
Fri, Oct 4, 1:38 PM
Unknown Object (File)
Fri, Oct 4, 1:36 PM

Details

Summary

We want to pull a LoginForm component out of LoginModal so it can be re-used in Splash.

Next diffs:

  1. Naively add LoginForm to Splash
  2. Style LoginForm so it looks decent in both Splash and LoginModal. Currently the LoginModal/LoginForm is styled using user-settings-modal.css. Will create a separate stylesheet for LoginForm but will cut/paste the styles to start with something consistent.
Test Plan
  1. yarn dev in web and server (to avoid any hot reloading artifacts).
  2. Go to localhost/comm/.
  3. Click "Log in".
  4. Click the X in the top-right corner to make sure the modal disappears.
  5. Enter invalid credentials and make sure error message + input focus is correct.
  6. Enter valid credentials and make sure we are correctly "redirected" to the app.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable