Paths

Table of Contentst

Differential D3492

[web] Add `LoginForm` to `Splash`
ClosedPublic
Actions

Authored by atul on Mar 22 2022, 3:25 PM.

Tags

None

Referenced Files

	F2905582: D3492.id10621.diff
	Sun, Oct 6, 6:43 AM

	F2905522: D3492.id10620.diff
	Sun, Oct 6, 6:18 AM

	F2905483: D3492.id10602.diff
	Sun, Oct 6, 5:59 AM

	Unknown Object (File)
	Fri, Sep 27, 7:15 AM

	Unknown Object (File)
	Fri, Sep 27, 7:15 AM

	Unknown Object (File)
	Fri, Sep 27, 7:15 AM

	Unknown Object (File)
	Fri, Sep 27, 7:15 AM

	Unknown Object (File)
	Fri, Sep 27, 7:14 AM

Subscribers

Details

Reviewers

tomek
• jacek
• benschac
ashoat

Commits

rCOMMb795a8bf4688: [web] Add `LoginForm` to `Splash`

Summary

Add LoginForm to Splash so users can log in directly without having to open a modal first.

Next diffs:

Style LoginForm so it looks decent in both Splash and LoginModal. Currently the LoginModal/LoginForm is styled using user-settings-modal.css. Will create a separate stylesheet for LoginForm but will cut/paste the styles to start with something consistent.

Test Plan

Here's how it looks (for now):

4451.png (1×3 px, 324 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Mar 22 2022, 3:25 PM

Herald added subscribers: • karol, • adrian. · View Herald TranscriptMar 22 2022, 3:25 PM

atul published this revision for review.Mar 22 2022, 3:26 PM

atul edited the test plan for this revision. (Show Details)

atul edited the summary of this revision. (Show Details)

Harbormaster completed remote builds in B7533: Diff 10602.Mar 22 2022, 3:30 PM

ashoat accepted this revision.Mar 22 2022, 10:02 PM

This revision is now accepted and ready to land.Mar 22 2022, 10:02 PM

rebase before landing

Harbormaster completed remote builds in B7550: Diff 10620.Mar 23 2022, 9:35 AM

Closed by commit rCOMMb795a8bf4688: [web] Add `LoginForm` to `Splash` (authored by atul). · Explain WhyMar 23 2022, 9:39 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMb795a8bf4688: [web] Add `LoginForm` to `Splash`.

Revision Contents
Changeset List

Path

Size

web/

splash/

splash.react.js

22 lines

Diff 10621

web/splash/splash.react.js

Loading...