[web] Add hover states to "Focus"/"Background" tabs
ClosedPublic
Actions

Authored by atul on Mar 30 2022, 1:21 PM.

Details

Reviewers

• jacek
tomek
• benschac

Commits

rCOMM519041e90b4c: [web] Add hover states to "Focus"/"Background" tabs

Summary

Quick thing to make things feel more interactive: https://linear.app/comm/issue/ENG-952/introduce-hover-states-for-focus-and-background-tabs

Test Plan

Looks as expected:

Diff Detail

Repository

rCOMM Comm

Branch

landmarch31 (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Mar 30 2022, 1:21 PM

Herald added subscribers: • abosh, • karol, • adrian, ashoat. · View Herald TranscriptMar 30 2022, 1:21 PM

atul edited the test plan for this revision. (Show Details)Mar 30 2022, 1:21 PM

atul added inline comments.

web/chat/chat-tabs.css
43 ↗	(On Diff #10845)	Also removed this extraneous `color` property for `tabItemInactive`.

atul published this revision for review.Mar 30 2022, 1:22 PM

atul retitled this revision from [web] Add hover states for "Focus"/"Background" tabs to [web] Add hover states to "Focus"/"Background" tabs.

Harbormaster completed remote builds in B7731: Diff 10845.Mar 30 2022, 1:27 PM

tomek accepted this revision.Mar 31 2022, 8:30 AM

This revision is now accepted and ready to land.Mar 31 2022, 8:30 AM

rebase before landing

Harbormaster completed remote builds in B7770: Diff 10897.Mar 31 2022, 8:50 AM

Closed by commit rCOMM519041e90b4c: [web] Add hover states to "Focus"/"Background" tabs (authored by atul). · Explain WhyMar 31 2022, 9:13 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM519041e90b4c: [web] Add hover states to "Focus"/"Background" tabs.

Revision Contents
Changeset List

Path

Size

web/

chat/

chat-tabs.css

6 lines

Diff 10897

View Options

[web] Add hover states to "Focus"/"Background" tabsClosedPublicActions