Page MenuHomePhabricator
Differential D3589

[web] Copy/paste `user-settings-modal.css` into `thread-settings-modal.css`
ClosedPublic
Actions

Authored by atul on Mar 31 2022, 11:19 AM.
Tags
None
Referenced Files
F3173366: D3589.id10914.diff
Thu, Nov 7, 3:24 PM
F3172100: D3589.id11015.diff
Thu, Nov 7, 2:21 PM
Unknown Object (File)
Wed, Nov 6, 11:38 AM
Unknown Object (File)
Wed, Nov 6, 11:38 AM
Unknown Object (File)
Wed, Nov 6, 11:38 AM
Unknown Object (File)
Tue, Nov 5, 1:33 AM
Unknown Object (File)
Oct 4 2024, 7:07 PM
Unknown Object (File)
Sep 24 2024, 10:32 PM
View All Files
Subscribers
• abosh
• adrian
• karol

Details

Reviewers
• jacek
tomek
• benschac
ashoat
Commits
rCOMM65be6b773f0e: [web] Copy/paste `user-settings-modal.css` into `thread-settings-modal.css`
Summary

noop

Next diffs:

  1. Move the styles used in thread-settings-modal.react from style.css to thread-settings-modal.css.
  2. "Consume" thread-settings-modal.css from thread-settings-modal.react instead of style.css.
  3. Remove extraneous selectors from thread-settings-modal.css that aren't used in thread-settings-modal.react.
  4. Fill in styles that are "used" by thread-settings-modal.react that don't actually exist anywhere in the repo (eg current-tab). Probably by looking through the git history to see what current-tab used to be.
  5. Style the ThreadSettingsModal component so it looks decent.
Test Plan

NA, literally copy/paste and the pasted code isn't even used anywhere

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mar 31 2022, 11:19 AM
Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMar 31 2022, 11:19 AM
atul edited the summary of this revision. (Show Details)Mar 31 2022, 11:21 AM

(Added @ashoat as first-pass reviewer since this seems "rubberstamp-able.")

atul published this revision for review.Mar 31 2022, 11:21 AM
Harbormaster completed remote builds in B7779: Diff 10914.Mar 31 2022, 11:25 AM
atul added a child revision: D3591: [web] Move styles in `style.css` used by `ThreadSettingsModal` to `thread-settings-modal.css`.Mar 31 2022, 12:01 PM
ashoat accepted this revision.Mar 31 2022, 8:53 PM
This revision is now accepted and ready to land.Mar 31 2022, 8:53 PM
atul updated this revision to Diff 11014.Apr 4 2022, 12:39 PM

rebase before landing

Harbormaster completed remote builds in B7845: Diff 11014.Apr 4 2022, 12:46 PM
Closed by commit rCOMM65be6b773f0e: [web] Copy/paste `user-settings-modal.css` into `thread-settings-modal.css` (authored by atul). · Explain WhyApr 4 2022, 12:52 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM65be6b773f0e: [web] Copy/paste `user-settings-modal.css` into `thread-settings-modal.css`.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
143 lines

Diff 10914

View Options

web/modals/threads/thread-settings-modal.css

Loading...