Page MenuHomePhabricator
Differential D3542

[web] Refactor `classNames` in `threadRow` to take object instead of array
ClosedPublic
Actions

Authored by • abosh on Mar 29 2022, 10:52 AM.
Tags
None
Referenced Files
F3357175: D3542.diff
Sat, Nov 23, 10:42 PM
Unknown Object (File)
Fri, Nov 15, 9:02 AM
Unknown Object (File)
Thu, Nov 14, 8:54 AM
Unknown Object (File)
Tue, Nov 5, 1:24 AM
Unknown Object (File)
Oct 19 2024, 10:49 AM
Unknown Object (File)
Oct 18 2024, 7:59 PM
Unknown Object (File)
Oct 18 2024, 7:13 PM
Unknown Object (File)
Oct 13 2024, 2:27 PM
View All Files
Subscribers
• adrian
ashoat
• benschac
• karol
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM5756589cec12: [web] Refactor `classNames` in `threadRow` to take object instead of array
rCOMM42b8f27463e0: [web] Refactor `classNames` in `threadRow` to take object instead of array
Summary

Pass object instead of array into classNames to make code more readable. Cut ternary operator and made everything more symmetric.

Test Plan

Ensured that output was the same before and after the change in Chrome/Safari.

Diff Detail

Repository
rCOMM Comm
Branch
april1st (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• abosh created this revision.Mar 29 2022, 10:52 AM
Herald added subscribers: • benschac, • karol, • adrian and 2 others. · View Herald TranscriptMar 29 2022, 10:52 AM
• abosh published this revision for review.Mar 29 2022, 10:53 AM
• abosh added 1 blocking reviewer(s): atul.
Harbormaster completed remote builds in B7682: Diff 10781.Mar 29 2022, 10:59 AM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 29 2022, 11:09 AM
Closed by commit rCOMM42b8f27463e0: [web] Refactor `classNames` in `threadRow` to take object instead of array (authored by • abosh). · Explain Why
This revision was automatically updated to reflect the committed changes.
• abosh added a commit: rCOMM42b8f27463e0: [web] Refactor `classNames` in `threadRow` to take object instead of array.
atul added a reverting change: rCOMM87c2f874f3f2: Revert "[web] Refactor `classNames` in `threadRow` to take object instead of….Mar 29 2022, 11:14 AM
• abosh reopened this revision.Mar 29 2022, 2:34 PM
• abosh updated this revision to Diff 10793.Mar 29 2022, 2:35 PM

Reopening diff

Harbormaster completed remote builds in B7691: Diff 10793.Mar 29 2022, 2:47 PM
atul accepted this revision.Mar 29 2022, 3:01 PM
This revision is now accepted and ready to land.Mar 29 2022, 3:01 PM
atul added a reviewer: ashoat.Mar 29 2022, 3:01 PM
This revision now requires review to proceed.Mar 29 2022, 3:01 PM
ashoat accepted this revision.Mar 30 2022, 10:15 PM
This revision is now accepted and ready to land.Mar 30 2022, 10:15 PM
• abosh updated this revision to Diff 10971.Apr 1 2022, 4:44 PM

Rebase before landing

This revision was landed with ongoing or failed builds.Apr 1 2022, 4:46 PM
Closed by commit rCOMM5756589cec12: [web] Refactor `classNames` in `threadRow` to take object instead of array (authored by • abosh). · Explain Why
This revision was automatically updated to reflect the committed changes.
• abosh added a commit: rCOMM5756589cec12: [web] Refactor `classNames` in `threadRow` to take object instead of array.
Harbormaster completed remote builds in B7808: Diff 10971.Apr 1 2022, 4:51 PM

Revision Contents
Changeset List

Diff 10971

View Options

web/chat/chat-thread-list-see-more-sidebars.react.js

Loading...