[web] [refactor] use assetUrl variable
ClosedPublic
Actions

Authored by • benschac on Apr 4 2022, 7:26 AM.

Details

Reviewers

atul
tomek
• jacek
• abosh

Commits

rCOMM18a5e194e034: [web] [refactor] use assetUrl variable

Summary

swap hard coded url for assetUrl variable like the rest of the project uses.

Image 2022-04-04 at 10.27.38 AM.jpg (618×1 px, 52 KB)

Test Plan

go to the keyserver page. arrow should render.

Diff Detail

Repository

rCOMM Comm

Branch

tiny-landing-refactor

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Apr 4 2022, 7:26 AM

Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 4 2022, 7:26 AM

• benschac edited the summary of this revision. (Show Details)Apr 4 2022, 7:28 AM

• benschac added reviewers: tomek, • jacek, • abosh.

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 4 2022, 7:41 AM

Harbormaster failed remote builds in B7838: Diff 11006!

• benschac requested review of this revision.Apr 4 2022, 10:54 AM

I think we can come up with a better name than assetURL? Maybe assetsCacheURLPrefix?

Just something to indicate that it's a prefix that we'll need to append the asset name to. iirc there was an issue before caused by confusing URL "part" names

This revision is now accepted and ready to land.Apr 4 2022, 3:17 PM

In D3611#98972, @atul wrote:

I think we can come up with a better name than assetURL? Maybe assetsCacheURLPrefix?

Just something to indicate that it's a prefix that we'll need to append the asset name to. iirc there was an issue before caused by confusing URL "part" names

Yeah, I can do that in a follow up diff.

This revision was landed with ongoing or failed builds.Apr 5 2022, 5:59 AM

Closed by commit rCOMM18a5e194e034: [web] [refactor] use assetUrl variable (authored by • benschac). · Explain Why

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM18a5e194e034: [web] [refactor] use assetUrl variable.