Page MenuHomePhabricator
Differential D3659

[landing] [fix] [ENG-982] add correct type to button
ClosedPublic
Actions

Authored by • benschac on Apr 7 2022, 12:28 PM.
Tags
None
Referenced Files
F3496694: D3659.id11230.diff
Thu, Dec 19, 2:02 PM
F3490511: D3659.id11196.diff
Wed, Dec 18, 4:31 PM
F3490369: D3659.id11231.diff
Wed, Dec 18, 3:57 PM
Unknown Object (File)
Wed, Dec 18, 1:06 PM
Unknown Object (File)
Nov 17 2024, 9:53 PM
Unknown Object (File)
Nov 17 2024, 6:27 AM
Unknown Object (File)
Nov 14 2024, 8:56 AM
Unknown Object (File)
Nov 14 2024, 8:56 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• karol
tomek

Details

Reviewers
atul
tomek
Commits
rCOMM9d05ca2720f1: [landing] [fix] [ENG-982] add correct type to button
Summary

add the same onClick type that's currently in web/ project's button onClick handler.

https://github.com/CommE2E/comm/blob/master/web/components/button.react.js#L9

https://linear.app/comm/issue/ENG-982/landing-button-onclick-type-incorrect

Test Plan

use <Button></Button> component in landing page

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.Apr 7 2022, 12:28 PM
Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 7 2022, 12:28 PM
• benschac edited the summary of this revision. (Show Details)Apr 7 2022, 12:30 PM
Harbormaster completed remote builds in B7991: Diff 11196.Apr 7 2022, 12:33 PM
• benschac requested review of this revision.Apr 7 2022, 12:33 PM
• benschac added a reviewer: tomek.Apr 7 2022, 1:04 PM
tomek accepted this revision.Apr 8 2022, 6:14 AM
tomek added inline comments.
landing/button.react.js
8 ↗(On Diff #11196)

It would be even better to use mixed as we aren't interested in the return type

This revision is now accepted and ready to land.Apr 8 2022, 6:14 AM
• benschac updated this revision to Diff 11230.Apr 8 2022, 6:40 AM

update return type to mixed

This revision was landed with ongoing or failed builds.Apr 8 2022, 6:43 AM
Closed by commit rCOMM9d05ca2720f1: [landing] [fix] [ENG-982] add correct type to button (authored by • benschac). · Explain Why
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM9d05ca2720f1: [landing] [fix] [ENG-982] add correct type to button.
Harbormaster failed remote builds in B8025: Diff 11230!Apr 8 2022, 6:44 AM
Harbormaster completed remote builds in B8025: Diff 11230.Apr 8 2022, 8:13 AM

Revision Contents
Changeset List

PathSize
landing/
2 lines

Diff 11231

View Options

landing/button.react.js

Loading...