Page MenuHomePhabricator
Differential D3709

[web] First pass at styling `ConcurrentModificationModal`
ClosedPublic
Actions

Authored by atul on Apr 11 2022, 3:56 PM.
Tags
None
Referenced Files
F3297881: D3709.id11329.diff
Sun, Nov 17, 3:34 AM
F3297861: D3709.id11436.diff
Sun, Nov 17, 3:28 AM
F3296602: D3709.diff
Sun, Nov 17, 1:50 AM
Unknown Object (File)
Fri, Nov 15, 9:05 AM
Unknown Object (File)
Fri, Nov 15, 9:05 AM
Unknown Object (File)
Thu, Nov 14, 4:36 PM
Unknown Object (File)
Thu, Nov 14, 4:36 PM
Unknown Object (File)
Sun, Nov 10, 12:37 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• benschac
• karol

Details

Reviewers
tomek
• jacek
Commits
rCOMM7c0ad9be2cb9: [web] First pass at styling `ConcurrentModificationModal`
Summary

Started with styles borrowed from thread-settings-modal.css and made some tweaks so it looks decent.

Before:

0469.png (364×710 px, 47 KB)

After:

1b7a.png (560×738 px, 66 KB)

Test Plan
  1. Replaced InvalidUploadModal in InputStateContainer with ConcurrentModificationModal to make it easy
  2. Dragged SVG into message list
  3. ConcurrentModificationModal looked as expected

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 11 2022, 3:56 PM
Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 11 2022, 3:56 PM
atul edited the summary of this revision. (Show Details)Apr 11 2022, 3:57 PM
atul updated this revision to Diff 11329.Apr 11 2022, 3:58 PM

.ok_button => .refresh_button

atul published this revision for review.Apr 11 2022, 3:58 PM
Harbormaster completed remote builds in B8101: Diff 11328.Apr 11 2022, 4:01 PM
Harbormaster failed remote builds in B8102: Diff 11329!Apr 12 2022, 8:29 AM
Harbormaster completed remote builds in B8102: Diff 11329.Apr 12 2022, 8:38 AM
tomek accepted this revision.Apr 13 2022, 4:23 AM
This revision is now accepted and ready to land.Apr 13 2022, 4:23 AM
atul updated this revision to Diff 11431.Apr 13 2022, 10:27 AM

rebase before landing

Harbormaster completed remote builds in B8166: Diff 11431.Apr 13 2022, 10:32 AM
Closed by commit rCOMM7c0ad9be2cb9: [web] First pass at styling `ConcurrentModificationModal` (authored by atul). · Explain WhyApr 13 2022, 10:33 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM7c0ad9be2cb9: [web] First pass at styling `ConcurrentModificationModal`.

Revision Contents
Changeset List

Diff 11328

View Options

web/modals/concurrent-modification-modal.css

Loading...
View Options

web/modals/concurrent-modification-modal.react.js

Loading...