Page MenuHomePhabricator

[native] Don't crash yarn cleaninstall if ios/android folders are missing
ClosedPublic

Authored by ashoat on Apr 12 2022, 8:26 AM.
Tags
None
Referenced Files
F3573719: D3712.id11563.diff
Sat, Dec 28, 3:14 PM
Unknown Object (File)
Wed, Dec 25, 9:21 PM
Unknown Object (File)
Sat, Dec 14, 3:18 PM
Unknown Object (File)
Nov 27 2024, 9:07 AM
Unknown Object (File)
Nov 25 2024, 8:44 PM
Unknown Object (File)
Nov 23 2024, 2:31 PM
Unknown Object (File)
Nov 23 2024, 2:21 PM
Unknown Object (File)
Nov 23 2024, 12:30 PM

Details

Summary

We don't want to have to copy these folders into the keyserver Docker image if we don't have to.

Depends on D3710

Test Plan

Make sure I can build the Node.js keyserver from Docker

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek added inline comments.
native/package.json
8–9

The approaches for both platforms differ significantly. Wondering if we can just rm -rf android/build app/build app/.cxx for Android? Or maybe we need to add || true for iOS

This revision is now accepted and ready to land.Apr 13 2022, 4:32 AM
native/package.json
8–9

The issue is the line cd android will crash if android does not exist. rm -rf will not crash if the folder doesn't exist.

I assume you mean rm -rf android/build android/app/build android/app/.cxx? Yeah, that would work. I can change to that

native/package.json
8–9

I assume you mean rm -rf android/build android/app/build android/app/.cxx? Yeah, that would work. I can change to that

Yes, that was my suggestion, thanks!

Update yarn clean-android