Page MenuHomePhabricator
Differential D3706

[web] Remove extraneous `.js` suffix at end of some imports
ClosedPublic
Actions

Authored by atul on Apr 11 2022, 2:57 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 11, 6:53 AM
Unknown Object (File)
Sun, Nov 10, 12:37 AM
Unknown Object (File)
Fri, Nov 8, 10:42 PM
Unknown Object (File)
Fri, Nov 8, 10:42 PM
Unknown Object (File)
Fri, Nov 8, 10:42 PM
Unknown Object (File)
Fri, Nov 8, 8:20 PM
Unknown Object (File)
Fri, Nov 8, 8:20 PM
Unknown Object (File)
Fri, Nov 8, 8:20 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
• benschac
• karol

Details

Reviewers
• jacek
tomek
ashoat
Commits
rCOMMac60b4fae07d: [web] Remove extraneous `.js` suffix at end of some imports
Summary

Noticed that my editor includes the .js suffix for JS files when it "auto-imports" them.

I'll look into an ESLint thing or something, but just figured I'd cut them for now.

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
landapril12 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Apr 11 2022, 2:57 PM
Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 11 2022, 2:57 PM
Harbormaster completed remote builds in B8098: Diff 11325.Apr 11 2022, 3:02 PM
atul requested review of this revision.Apr 11 2022, 3:02 PM
ashoat accepted this revision.Apr 12 2022, 11:27 AM

Seems fine, although I think Node's ESM support eventually will want the .js suffix included. (That's why we have to use --experimental-specifier-resolution=node)

This revision is now accepted and ready to land.Apr 12 2022, 11:27 AM
atul added a comment.Apr 12 2022, 11:38 AM

Seems fine, although I think Node's ESM support eventually will want the .js suffix included.

Ah gotcha, guess it's not a huge deal either way for now then?

atul updated this revision to Diff 11371.Apr 12 2022, 12:13 PM

rebase before landing

Harbormaster completed remote builds in B8135: Diff 11371.Apr 12 2022, 12:17 PM
Closed by commit rCOMMac60b4fae07d: [web] Remove extraneous `.js` suffix at end of some imports (authored by atul). · Explain WhyApr 12 2022, 12:21 PM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMac60b4fae07d: [web] Remove extraneous `.js` suffix at end of some imports.
ashoat added a comment.Apr 13 2022, 11:19 AM

Ah gotcha, guess it's not a huge deal either way for now then?

Yeah, and I agree consistency is a good thing so this diff makes sense

Revision Contents
Changeset List

PathSize
landing/
2 lines
lib/
shared/
2 lines
utils/
2 lines
web/
chat/
6 lines
modals/
account/
2 lines
sidebar/
2 lines

Diff 11371

View Options

landing/team.react.js

Loading...
View Options

lib/shared/emojis.js

Loading...
View Options

lib/utils/message-ops-utils.test.js

Loading...
View Options

web/chat/message-action-buttons.js

Loading...
View Options

web/modals/account/log-in-modal.react.js

Loading...
View Options

web/sidebar/community-picker.react.js

Loading...