Page MenuHomePhabricator

[web] Remove "active" `transition` for `ColorSelectorButton` component
ClosedPublic

Authored by atul on Apr 12 2022, 12:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 8, 1:52 AM
Unknown Object (File)
Sun, Dec 8, 1:52 AM
Unknown Object (File)
Sun, Dec 8, 1:52 AM
Unknown Object (File)
Nov 17 2024, 1:50 AM
Unknown Object (File)
Nov 16 2024, 11:49 PM
Unknown Object (File)
Nov 16 2024, 9:19 PM
Unknown Object (File)
Nov 9 2024, 10:47 PM
Unknown Object (File)
Nov 5 2024, 8:58 PM

Details

Diff Detail

Repository
rCOMM Comm
Branch
landapril13 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul requested review of this revision.Apr 12 2022, 12:47 PM

Feels a lot more responsive! At some point we can consider adding some effect when clicking (a spring?), but it's really not worth it now.

This revision is now accepted and ready to land.Apr 13 2022, 4:26 AM

At some point we can consider adding some effect when clicking (a spring?), but it's really not worth it now.

Looked at examples of other color pickers (in other apps and on Dribbble) and there's definitely a lot we can do here to make the ColorSelector more interactive. But it does seem like more of a fit and finish thing that we should defer for later