Page MenuHomePhabricator
Differential D3714

[web] Remove "active" `transition` for `ColorSelectorButton` component
ClosedPublic
Actions

Authored by atul on Apr 12 2022, 12:41 PM.
Tags
None
Referenced Files
F3494132: D3714.id11439.diff
Thu, Dec 19, 4:25 AM
F3494131: D3714.id11437.diff
Thu, Dec 19, 4:25 AM
F3494129: D3714.id11374.diff
Thu, Dec 19, 4:25 AM
F3494106: D3714.id.diff
Thu, Dec 19, 4:24 AM
F3494087: D3714.diff
Thu, Dec 19, 4:21 AM
Unknown Object (File)
Sun, Dec 8, 1:52 AM
Unknown Object (File)
Sun, Dec 8, 1:52 AM
Unknown Object (File)
Sun, Dec 8, 1:52 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
• benschac
• karol
tomek

Details

Reviewers
• jacek
tomek
Commits
rCOMM38632c63ef00: [web] Remove "active" `transition` for `ColorSelectorButton` component
Summary

Addresses feedback from @palys-swm here: https://phabricator.ashoat.com/D3699#101943

Test Plan

Looks as expected:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

atul created this revision.Apr 12 2022, 12:41 PM
Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 12 2022, 12:41 PM
atul edited the test plan for this revision. (Show Details)Apr 12 2022, 12:46 PM
Harbormaster completed remote builds in B8137: Diff 11374.Apr 12 2022, 12:47 PM
atul requested review of this revision.Apr 12 2022, 12:47 PM
tomek accepted this revision.Apr 13 2022, 4:26 AM

Feels a lot more responsive! At some point we can consider adding some effect when clicking (a spring?), but it's really not worth it now.

This revision is now accepted and ready to land.Apr 13 2022, 4:26 AM
atul updated this revision to Diff 11437.Apr 13 2022, 10:34 AM

rebase before landing

atul added a comment.Apr 13 2022, 10:35 AM

At some point we can consider adding some effect when clicking (a spring?), but it's really not worth it now.

Looked at examples of other color pickers (in other apps and on Dribbble) and there's definitely a lot we can do here to make the ColorSelector more interactive. But it does seem like more of a fit and finish thing that we should defer for later

Harbormaster completed remote builds in B8171: Diff 11437.Apr 13 2022, 10:49 AM
Closed by commit rCOMM38632c63ef00: [web] Remove "active" `transition` for `ColorSelectorButton` component (authored by atul). · Explain WhyApr 13 2022, 10:56 AM
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM38632c63ef00: [web] Remove "active" `transition` for `ColorSelectorButton` component.

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
2 lines

Diff 11439

View Options

web/modals/threads/color-selector-button.css

Loading...