[web] [chore] [ENG-1010] add flow disable comment
AbandonedPublic
Actions

Authored by • benschac on Apr 15 2022, 1:47 PM.

Tags

None

Referenced Files

	F2905392: D3752.id11527.diff
	Sun, Oct 6, 5:12 AM

	Unknown Object (File)
	Fri, Oct 4, 2:39 PM

	Unknown Object (File)
	Fri, Oct 4, 2:39 PM

	Unknown Object (File)
	Fri, Oct 4, 2:37 PM

	Unknown Object (File)
	Sun, Sep 29, 4:21 AM

	Unknown Object (File)
	Thu, Sep 19, 9:28 PM

	Unknown Object (File)
	Aug 30 2024, 4:56 AM

	Unknown Object (File)
	Aug 29 2024, 10:34 PM

Subscribers

Details

Reviewers

atul
tomek
• jacek
• abosh

Summary

Currently, if you're using vscode and want to edit this file you'll see red swiggles everywhere. we should disable flow here if were not checking it.

https://linear.app/comm/issue/ENG-1010/webpack-linting-chore

Test Plan

everything still works as expected.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Apr 15 2022, 1:47 PM

Herald added subscribers: • abosh, • karol, • adrian and 2 others. · View Herald TranscriptApr 15 2022, 1:47 PM

• benschac added a child revision: D3753: [web] [chore] [ENG-1010] fix linting issues.Apr 15 2022, 1:50 PM

• benschac retitled this revision from [web] [chore] add flow disable comment to [web] [chore] [ENG-1010] add flow disable comment.Apr 15 2022, 1:58 PM

Harbormaster completed remote builds in B8242: Diff 11527.Apr 15 2022, 2:00 PM

• benschac requested review of this revision.Apr 15 2022, 2:00 PM

• benschac edited the summary of this revision. (Show Details)Apr 18 2022, 7:23 AM

• benschac added reviewers: tomek, • jacek, • abosh.

Per @atul comment, we can ignore entire files from the config, which is done in this diff: https://phabricator.ashoat.com/D3761

closing this diff in favor of 3761

Revision Contents
Changeset List

Path

Size

web/

webpack.config.cjs

2 lines

Diff 11527

View Options

[web] [chore] [ENG-1010] add flow disable commentAbandonedPublicActions