Paths

Table of Contentst

Differential D3712

[native] Don't crash yarn cleaninstall if ios/android folders are missing
ClosedPublic
Actions

Authored by ashoat on Apr 12 2022, 8:26 AM.

Tags

None

Referenced Files

	F3354242: D3712.diff
	Sat, Nov 23, 12:30 PM

	Unknown Object (File)
	Thu, Nov 14, 4:26 AM

	Unknown Object (File)
	Mon, Nov 11, 11:19 PM

	Unknown Object (File)
	Fri, Nov 8, 9:45 AM

	Unknown Object (File)
	Sun, Nov 3, 9:31 PM

	Unknown Object (File)
	Oct 23 2024, 3:06 AM

	Unknown Object (File)
	Oct 23 2024, 2:52 AM

	Unknown Object (File)
	Oct 20 2024, 2:43 AM

Subscribers

Details

Reviewers

tomek
• jim

Commits

rCOMMa50211b43b08: [native] Don't crash yarn cleaninstall if ios/android folders are missing

Summary

We don't want to have to copy these folders into the keyserver Docker image if we don't have to.

Depends on D3710

Test Plan

Make sure I can build the Node.js keyserver from Docker

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Apr 12 2022, 8:26 AM

Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 12 2022, 8:26 AM

ashoat added a child revision: D3713: yarn cleaninstall from Docker image.Apr 12 2022, 8:27 AM

Harbormaster completed remote builds in B8125: Diff 11353.Apr 12 2022, 8:36 AM

ashoat requested review of this revision.Apr 12 2022, 8:36 AM

tomek accepted this revision.Apr 13 2022, 4:32 AM

tomek added inline comments.

native/package.json
8–9 ↗	(On Diff #11353)	The approaches for both platforms differ significantly. Wondering if we can just `rm -rf android/build app/build app/.cxx` for Android? Or maybe we need to add `\|\| true` for iOS

This revision is now accepted and ready to land.Apr 13 2022, 4:32 AM

ashoat added inline comments.Apr 13 2022, 11:24 AM

native/package.json
8–9 ↗	(On Diff #11353)	The issue is the line `cd android` will crash if `android` does not exist. `rm -rf` will not crash if the folder doesn't exist. I assume you mean `rm -rf android/build android/app/build android/app/.cxx`? Yeah, that would work. I can change to that

tomek added inline comments.Apr 14 2022, 12:40 AM

native/package.json
8–9 ↗	(On Diff #11353)	I assume you mean rm -rf android/build android/app/build android/app/.cxx? Yeah, that would work. I can change to that Yes, that was my suggestion, thanks!

Update yarn clean-android

Harbormaster completed remote builds in B8247: Diff 11536.Apr 17 2022, 6:24 PM

Closed by commit rCOMMa50211b43b08: [native] Don't crash yarn cleaninstall if ios/android folders are missing (authored by ashoat). · Explain WhyApr 18 2022, 12:16 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMa50211b43b08: [native] Don't crash yarn cleaninstall if ios/android folders are missing.

Revision Contents
Changeset List

Path

Size

native/

4 lines

Diff 11536

native/package.json

Loading...