add error boundary to the web app, when the project crashes, end user gets a message.
https://linear.app/comm/issue/ENG-813/add-error-boundaries
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- benjamin/eng-813-add-error-boundarieswd
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/error-boundary.react.js | ||
|---|---|---|
| 30 | this is never used. Going to remove it. | |
| web/error-boundary.react.js | ||
|---|---|---|
| 9–16 ↗ | (On Diff #11757) | Once again you're writing code without making types $ReadOnly. What is it going to take to get this right once-and-for-all, so you never submit code with this error again? |
Comment Actions
update types
| web/error-boundary.react.js | ||
|---|---|---|
| 9–16 ↗ | (On Diff #11757) | Obviously, not an excuse. I should have caught this on my own. I did a copy/pasta of native/error-boundry.react.js and should have double checked. I'm going to fix this in native too. Sorry! |
| web/error-boundary.react.js | ||
|---|---|---|
| 9–16 ↗ | (On Diff #11757) |
I'm not really sure this is a constructive question/dialog to have in code review. If I knew I wouldn't have made the error in the first place. Happy to talk IRL. |
Comment Actions
Followed up offline, @benschac has a code snippet he'll be using going forward which should hopefully help, and he's going to try to move a bit slower with stuff as a tradeoff to catch more things
Comment Actions
Added reference to the snippets in notion: https://www.notion.so/commapp/VSCode-setup-1ec2d3fefb0c416e88adce8a8ebad21c if anyone else is interested in using them.