web/error-boundary.react.js
9–16	Once again you're writing code without making types `$ReadOnly`. What is it going to take to get this right once-and-for-all, so you never submit code with this error again?

This revision now requires changes to proceed.Apr 22 2022, 6:24 AM

update types

web/error-boundary.react.js
9–16	Obviously, not an excuse. I should have caught this on my own. I did a copy/pasta of `native/error-boundry.react.js` and should have double checked. I'm going to fix this in `native` too. Sorry!

• benschac added inline comments.Apr 22 2022, 6:56 AM

web/error-boundary.react.js
9–16	What is it going to take to get this right once-and-for-all, so you never submit code with this error again? I'm not really sure this is a constructive question/dialog to have in code review. If I knew I wouldn't have made the error in the first place. Happy to talk IRL.

Harbormaster completed remote builds in B8463: Diff 11802.Apr 22 2022, 7:00 AM

• benschac mentioned this in D3816: [web,native] [chore] [ENG-1032] add covariant declarations to props that were missing.Apr 22 2022, 8:06 AM

Followed up offline, @benschac has a code snippet he'll be using going forward which should hopefully help, and he's going to try to move a bit slower with stuff as a tradeoff to catch more things

This revision is now accepted and ready to land.Apr 24 2022, 4:32 PM

Added reference to the snippets in notion: https://www.notion.so/commapp/VSCode-setup-1ec2d3fefb0c416e88adce8a8ebad21c if anyone else is interested in using them.

Closed by commit rCOMM793f9b9df77f: [web] [feat/chore] [ENG-813] add error boundary to the app (authored by • benschac). · Explain WhyApr 25 2022, 5:19 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMM793f9b9df77f: [web] [feat/chore] [ENG-813] add error boundary to the app.

• benschac mentioned this in rCOMMbdc048e8d4f5: [web,native] [chore] [ENG-1032] add covariant declarations to props that were….Apr 25 2022, 5:23 AM