Paths

Table of Contentst

[web,native] [chore] [ENG-1032] add covariant declarations to props that were missing
ClosedPublic
Actions

Authored by • benschac on Apr 22 2022, 8:06 AM.

Details

Reviewers

atul
tomek
ashoat
• jacek
• abosh

Commits

rCOMMbdc048e8d4f5: [web,native] [chore] [ENG-1032] add covariant declarations to props that were…

Summary

https://linear.app/comm/issue/ENG-1032/add-missing-covariant-declarations-in-web-and-native

Test Plan

run flow on native and web adding @ashoat as a reviewer because this was initially a comment of D3811

Diff Detail

Repository

rCOMM Comm

Branch

benjamin/eng-813-add-error-boundarieswd

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.Apr 22 2022, 8:06 AM

Herald added subscribers: • karol, • adrian. · View Herald TranscriptApr 22 2022, 8:06 AM

• benschac mentioned this in D3815: [native] [chore] [ENG-1032] make props and state covariant.Apr 22 2022, 8:10 AM

add changes from D3815

Harbormaster failed remote builds in B8466: Diff 11805!Apr 22 2022, 8:13 AM

Harbormaster completed remote builds in B8467: Diff 11806.Apr 22 2022, 8:18 AM

• benschac requested review of this revision.Apr 22 2022, 8:18 AM

ashoat accepted this revision.Apr 24 2022, 4:33 PM

This revision is now accepted and ready to land.Apr 24 2022, 4:33 PM

Closed by commit rCOMMbdc048e8d4f5: [web,native] [chore] [ENG-1032] add covariant declarations to props that were… (authored by • benschac). · Explain WhyApr 25 2022, 5:23 AM

This revision was automatically updated to reflect the committed changes.

• benschac added a commit: rCOMMbdc048e8d4f5: [web,native] [chore] [ENG-1032] add covariant declarations to props that were….

Revision Contents
Changeset List

Path

Size

native/

calendar/

loading-indicator.react.js

6 lines

thread-picker-modal.react.js

4 lines

chat/

new-messages-pill.react.js

8 lines

components/

clearable-text-input.react.ios.js

2 lines

content-loading.react.js

4 lines

single-line.react.js

2 lines

error-boundary.react.js

4 lines

media/

send-media-button.react.js

8 lines

navigation/

action-result-modal.react.js

4 lines

header.react.js

2 lines

modal-pruner.react.js

2 lines

profile/

custom-server-modal.react.js

2 lines

push/

in-app-notif.react.js

6 lines

web/

calendar/

calendar.react.js

2 lines

chat/

chat-message-list.react.js

4 lines

Diff 11806

View Options

native/calendar/loading-indicator.react.js

View Options

native/calendar/thread-picker-modal.react.js

View Options

native/chat/new-messages-pill.react.js

View Options

native/components/clearable-text-input.react.ios.js

View Options

native/components/content-loading.react.js

View Options

native/components/single-line.react.js

View Options

native/error-boundary.react.js

View Options

native/media/send-media-button.react.js

View Options

native/navigation/action-result-modal.react.js

View Options

native/navigation/header.react.js

View Options

native/navigation/modal-pruner.react.js

View Options

native/profile/custom-server-modal.react.js

View Options

native/push/in-app-notif.react.js

View Options

web/calendar/calendar.react.js

View Options

web/chat/chat-message-list.react.js

[web,native] [chore] [ENG-1032] add covariant declarations to props that were missingClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 11806

native/calendar/loading-indicator.react.js

native/calendar/thread-picker-modal.react.js

native/chat/new-messages-pill.react.js

native/components/clearable-text-input.react.ios.js

native/components/content-loading.react.js

native/components/single-line.react.js

native/error-boundary.react.js

native/media/send-media-button.react.js

native/navigation/action-result-modal.react.js

native/navigation/header.react.js

native/navigation/modal-pruner.react.js

native/profile/custom-server-modal.react.js

native/push/in-app-notif.react.js

web/calendar/calendar.react.js

web/chat/chat-message-list.react.js

[web,native] [chore] [ENG-1032] add covariant declarations to props that were missing
ClosedPublic
Actions

Revision Contents
Changeset List