[keyserver] Get rid of container_name for Node in docker-compose.yml
ClosedPublic
Actions

Authored by ashoat on Apr 25 2022, 7:46 PM.

Details

Reviewers

tomek
• jim

Commits

rCOMMf7c00984513b: [keyserver] Get rid of container_name for Node in docker-compose.yml

Summary

From docs:

Because Docker container names must be unique, you cannot scale a service beyond 1 container if you have specified a custom name.

@jimpo also highlighted this in his review of D3713.

Test Plan

N/A

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Apr 25 2022, 7:46 PM

Herald added subscribers: • abosh, • karol, atul, • adrian. · View Herald TranscriptApr 25 2022, 7:46 PM

ashoat added a child revision: D3848: [keyserver] Add rsync to Dockerfile.Apr 25 2022, 7:47 PM

Harbormaster completed remote builds in B8535: Diff 11897.Apr 25 2022, 7:51 PM

ashoat requested review of this revision.Apr 25 2022, 7:51 PM

tomek accepted this revision.Apr 26 2022, 9:36 AM

This revision is now accepted and ready to land.Apr 26 2022, 9:36 AM

Closed by commit rCOMMf7c00984513b: [keyserver] Get rid of container_name for Node in docker-compose.yml (authored by ashoat). · Explain WhyApr 27 2022, 11:40 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf7c00984513b: [keyserver] Get rid of container_name for Node in docker-compose.yml.

tomek mentioned this in D3964: [services] Tunnelbroker - RabbitMQ Docker image for dev environment.May 9 2022, 7:14 AM

• max mentioned this in D4014: [services] Remove `container_name` from docker-compose file.May 12 2022, 4:59 AM

• max mentioned this in rCOMM53b692443067: [services] Remove `container_name` from docker-compose file.May 13 2022, 5:27 AM

Revision Contents
Changeset List

Path

Size

keyserver/

docker-compose.yml

1 line

Diff 11897

View Options

keyserver/docker-compose.yml

[keyserver] Get rid of container_name for Node in docker-compose.ymlClosedPublicActions