Differential D3847

[keyserver] Get rid of container_name for Node in docker-compose.yml
ClosedPublic
Actions

Authored by ashoat on Apr 25 2022, 7:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 4, 7:15 AM

	Unknown Object (File)
	Mon, Mar 31, 9:58 PM

	Unknown Object (File)
	Mon, Mar 31, 4:40 PM

	Unknown Object (File)
	Mon, Mar 31, 6:50 AM

	Unknown Object (File)
	Sun, Mar 30, 9:18 PM

	Unknown Object (File)
	Sat, Mar 29, 9:38 PM

	Unknown Object (File)
	Thu, Mar 27, 4:31 AM

	Unknown Object (File)
	Thu, Mar 13, 12:37 PM

Subscribers

Details

Reviewers

tomek
• jim

Commits

rCOMMf7c00984513b: [keyserver] Get rid of container_name for Node in docker-compose.yml

Summary

From docs:

Because Docker container names must be unique, you cannot scale a service beyond 1 container if you have specified a custom name.

@jimpo also highlighted this in his review of D3713.

Test Plan

N/A

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Apr 25 2022, 7:46 PM

Herald added subscribers: • abosh, • karol, atul, • adrian. · View Herald TranscriptApr 25 2022, 7:46 PM

ashoat added a child revision: D3848: [keyserver] Add rsync to Dockerfile.Apr 25 2022, 7:47 PM

Harbormaster completed remote builds in B8535: Diff 11897.Apr 25 2022, 7:51 PM

ashoat requested review of this revision.Apr 25 2022, 7:51 PM

tomek accepted this revision.Apr 26 2022, 9:36 AM

This revision is now accepted and ready to land.Apr 26 2022, 9:36 AM

Closed by commit rCOMMf7c00984513b: [keyserver] Get rid of container_name for Node in docker-compose.yml (authored by ashoat). · Explain WhyApr 27 2022, 11:40 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf7c00984513b: [keyserver] Get rid of container_name for Node in docker-compose.yml.

tomek mentioned this in D3964: [services] Tunnelbroker - RabbitMQ Docker image for dev environment.May 9 2022, 7:14 AM

• max mentioned this in D4014: [services] Remove `container_name` from docker-compose file.May 12 2022, 4:59 AM

• max mentioned this in rCOMM53b692443067: [services] Remove `container_name` from docker-compose file.May 13 2022, 5:27 AM

Revision Contents
Changeset List

Path

Size

keyserver/

docker-compose.yml

1 line

Diff 12000

keyserver/docker-compose.yml

This file was moved from keyserver/flow-typed/npm/@matrix-org/olm_vx.x.x.js.

	// flow-typed signature: 085f002da86534cfd8cee47ffa99dd67			// flow-typed signature: 085f002da86534cfd8cee47ffa99dd67
	// flow-typed version: <<STUB>>/@matrix-org/olm_v3.2.4/flow_v0.182.0			// flow-typed version: <<STUB>>/@commapp/olm_v3.2.4/flow_v0.182.0

	declare module '@matrix-org/olm' {			declare module '@commapp/olm' {

	/*			/*
	Copyright 2020 The Matrix.org Foundation C.I.C.			Copyright 2020 The Matrix.org Foundation C.I.C.

	Licensed under the Apache License, Version 2.0 (the "License");			Licensed under the Apache License, Version 2.0 (the "License");
	you may not use this file except in compliance with the License.			you may not use this file except in compliance with the License.
	You may obtain a copy of the License at			You may obtain a copy of the License at

	▲ Show 20 Lines • Show All 163 Lines • Show Last 20 Lines