Page MenuHomePhabricator

[keyserver] Defer Redis publisher construction until actually used
ClosedPublic

Authored by ashoat on Apr 27 2022, 8:13 PM.
Tags
None
Referenced Files
F3359730: D3870.diff
Sun, Nov 24, 10:38 AM
Unknown Object (File)
Fri, Nov 22, 1:49 PM
Unknown Object (File)
Fri, Nov 22, 1:49 PM
Unknown Object (File)
Fri, Nov 22, 1:49 PM
Unknown Object (File)
Fri, Nov 22, 1:49 PM
Unknown Object (File)
Thu, Nov 14, 4:37 PM
Unknown Object (File)
Thu, Nov 14, 4:37 PM
Unknown Object (File)
Thu, Nov 14, 9:06 AM

Details

Summary

The current behavior means that anything that inadvertedly imports redis.js (update-geoip.js, for instance) will crash if it can't reach Redis.

This diff makes it so RedisPublisher only tries to connect to Redis on the first call to sendMessage().

Test Plan

Make sure yarn update-geoip works from a Docker buildscript

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/dockerize_node
Lint
No Lint Coverage
Unit
No Test Coverage