Add image thumbnail and website description (from Twitter bio) for the landing page so it appears in Twitter Cards/Facebook messages/posts when shared.
Related Linear issues with full context: ENG-1066.
Differential D3886
[landing] Add thumbnail and description for landing page when shared • abosh on May 2 2022, 7:29 AM. Authored by Tags None Referenced Files
Subscribers
Details Add image thumbnail and website description (from Twitter bio) for the landing page so it appears in Twitter Cards/Facebook messages/posts when shared. Related Linear issues with full context: ENG-1066. N/A, as of now. There is no staging environment with a public URL so not sure how to test these changes yet. This is tracked by ENG-889 (FB called this "Sandcastle"). Once there is, though:
Diff Detail
Event Timeline
Comment Actions
I think this is a different thing. From what I understand, this diff is about link previews (relevant to messaging apps/twitter/etc.) IIRC Sandcastle is about deploy previews (https://www.latonyadesign.com/gallery/fb-sandcastle). eg you put a diff up and the reviewer is provided with a link to some sort of staging environment/deploy preview. Comment Actions yeah, you're right. I saw it in the Linear issue and wanted to add it to bridge the contexts between the two issues, since we need to add a staging environment with a deploy preview to test this diff. Just edited the Test Plan to accurately describe what in this issue is related to Sandcastle.
Comment Actions (Based on my reading of the docs, and that this diff adds metadata that doesn't affect any functionality, I think this is safe to land) |