[web] Remove extraneous `border-radius` property in `modal.css: modalContainer`
ClosedPublic
Actions

Authored by atul on May 2 2022, 12:31 PM.

Details

Reviewers

• jacek
tomek
• benschac
ashoat

Commits

rCOMMb28027302a74: [web] Remove extraneous `border-radius` property in `modal.css: modalContainer`

Summary

This is getting overridden by the border-radius: 8px below so it isn't having any effect.

The second instance is from 6 days ago and the first is from 3 months ago, so guessing the border-radius from 6 days ago "is the right one."

Test Plan

Put code editor and modal side by side
Comment out first border-radius property
Check that appearance of modal doesn't change
Manually change the border-radius to 15px to make sure I would have noticed the visual change

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.May 2 2022, 12:31 PM

Herald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMay 2 2022, 12:31 PM

atul published this revision for review.May 2 2022, 12:32 PM

atul retitled this revision from [web] Remove extraneous `border-radius` property in `div.modalContainer` to [web] Remove extraneous `border-radius` property in `modal.css:div.modalContainer`.

atul retitled this revision from [web] Remove extraneous `border-radius` property in `modal.css:div.modalContainer` to [web] Remove extraneous `border-radius` property in `modal.css: modalContainer`.

Harbormaster completed remote builds in B8723: Diff 12150.May 2 2022, 12:36 PM

ashoat accepted this revision.May 2 2022, 12:50 PM

This revision is now accepted and ready to land.May 2 2022, 12:50 PM

Closed by commit rCOMMb28027302a74: [web] Remove extraneous `border-radius` property in `modal.css: modalContainer` (authored by atul). · Explain WhyMay 2 2022, 12:58 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMb28027302a74: [web] Remove extraneous `border-radius` property in `modal.css: modalContainer`.