Page MenuHomePhabricator
Differential D3781

[services] Tunnelbroker - Database findMessageItemsByReceiver tests
ClosedPublic
Actions

Authored by • max on Apr 19 2022, 7:02 AM.
Tags
None
Referenced Files
F2786058: D3781.id12191.diff
Fri, Sep 20, 9:46 PM
F2785708: D3781.diff
Fri, Sep 20, 7:43 PM
Unknown Object (File)
Thu, Sep 12, 2:59 AM
Unknown Object (File)
Mon, Sep 9, 5:06 PM
Unknown Object (File)
Mon, Sep 9, 5:06 PM
Unknown Object (File)
Mon, Sep 9, 5:06 PM
Unknown Object (File)
Mon, Sep 9, 5:05 PM
Unknown Object (File)
Mon, Sep 9, 5:03 PM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
• benschac
• karol
tomek

Details

Reviewers
• karol
tomek
Commits
rCOMM125b7b3a97e6: [services] Tunnelbroker - Database findMessageItemsByReceiver tests
Summary

Database (DynamoDB) findMessageItemsByReceiver function tests:

  • Check if the table is available,
  • Create and fulfill database MessageItem entity,
  • Put the item into the database table,
  • Find the records by the ToDeviceID field key using findMessageItemsByReceiver function (D3239),
  • Compare first record fields of created item and item from database record,
  • Remove the testing record from the database.
Test Plan

Run yarn test-tunnelbroker-service all tests are run and succeed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• max created this revision.Apr 19 2022, 7:02 AM
Herald added subscribers: • abosh, • benschac, • karol and 4 others. · View Herald TranscriptApr 19 2022, 7:02 AM
• max added a parent revision: D3239: [services] Tunnelbroker - DatabaseManager method to find messages by the receiver.Apr 19 2022, 7:03 AM
• max edited the summary of this revision. (Show Details)
• max added reviewers: • karol, tomek.
• max mentioned this in D3239: [services] Tunnelbroker - DatabaseManager method to find messages by the receiver.Apr 19 2022, 7:05 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Apr 19 2022, 10:53 AM
Harbormaster failed remote builds in B8309: Diff 11606!
• max requested review of this revision.Apr 20 2022, 4:21 AM
tomek accepted this revision.Apr 20 2022, 10:02 AM
tomek added inline comments.
services/tunnelbroker/test/DatabaseManagerTest.cpp
26 ↗(On Diff #11606)

We should probably use past tense here

This revision is now accepted and ready to land.Apr 20 2022, 10:02 AM
• max mentioned this in rCOMMd4d31dcce367: [services] Tunnelbroker - DatabaseManager method to find messages by the….May 4 2022, 1:10 AM
• max updated this revision to Diff 12191.May 4 2022, 1:50 AM

Rebase on master, test name changed to follow the codebase.

• max marked an inline comment as done.May 4 2022, 1:52 AM
• max added inline comments.
services/tunnelbroker/test/DatabaseManagerTest.cpp
26 ↗(On Diff #11606)

We should probably use past tense here

I've switched to the updated test name following our names convention.

Harbormaster completed remote builds in B8749: Diff 12191.May 4 2022, 1:54 AM
Closed by commit rCOMM125b7b3a97e6: [services] Tunnelbroker - Database findMessageItemsByReceiver tests (authored by • max). · Explain WhyMay 4 2022, 2:03 AM
This revision was automatically updated to reflect the committed changes.
• max marked an inline comment as done.
• max added a commit: rCOMM125b7b3a97e6: [services] Tunnelbroker - Database findMessageItemsByReceiver tests.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
test/
35 lines

Diff 12192

View Options

services/tunnelbroker/test/DatabaseManagerTest.cpp

Loading...