Paths

Table of Contentst

Differential D3898

[keyserver] Consistency for keyserver/bash folder
ClosedPublic
Actions

Authored by ashoat on May 3 2022, 10:12 AM.

Tags

None

Referenced Files

	F3378457: D3898.id12175.diff
	Wed, Nov 27, 10:42 AM

	F3378054: D3898.diff
	Wed, Nov 27, 8:47 AM

	Unknown Object (File)
	Thu, Nov 14, 9:08 AM

	Unknown Object (File)
	Thu, Nov 14, 9:07 AM

	Unknown Object (File)
	Thu, Nov 7, 3:08 PM

	Unknown Object (File)
	Sun, Nov 3, 3:18 PM

	Unknown Object (File)
	Oct 20 2024, 1:00 AM

	Unknown Object (File)
	Oct 19 2024, 11:16 AM

Subscribers

Details

Reviewers

atul
varun

Commits

rCOMM5f683d1b0dd9: [keyserver] Consistency for keyserver/bash folder

Summary

chmod 755 source-nvm.sh (other files have executable bit set)
git mv backup_phabricator.sh backup-phabricator.sh (other files use dashes instead of underscores)

Test Plan

I updated the prod cronjob for backing up Phabricator (which isn't running right now anyways, currently relying on AWS RDS)
I git grep'd for backup_phabricator and found nothing
I'm fairly confident chmod 755 will have no ill effects

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 3 2022, 10:12 AM

Herald added subscribers: • abosh, • karol, • adrian, tomek. · View Herald TranscriptMay 3 2022, 10:12 AM

Fix typo in code comment

Harbormaster completed remote builds in B8737: Diff 12174.May 3 2022, 10:17 AM

Harbormaster completed remote builds in B8738: Diff 12175.May 3 2022, 10:21 AM

ashoat requested review of this revision.May 3 2022, 10:21 AM

varun accepted this revision.May 4 2022, 10:22 AM

This revision is now accepted and ready to land.May 4 2022, 10:22 AM

Closed by commit rCOMM5f683d1b0dd9: [keyserver] Consistency for keyserver/bash folder (authored by ashoat). · Explain WhyMay 4 2022, 11:17 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM5f683d1b0dd9: [keyserver] Consistency for keyserver/bash folder.

Revision Contents
Changeset List

Path

Size

keyserver/

bash/

	backup-phabricator.sh
	backup_phabricator.sh

backup_phabricator.sh

2 lines

Diff 12234

keyserver/bash/backup-phabricator.sh

Loading...

keyserver/bash/backup_phabricator.sh

Loading...

keyserver/bash/run-prod.sh

Loading...

keyserver/bash/source-nvm.sh

Loading...