Page MenuHomePhabricator
Differential D3919

[native,lib,keyserver,web] [fix] [ENG-1083] fix comments that are too long
ClosedPublic
Actions

Authored by • benschac on May 4 2022, 11:18 AM.
Tags
None
Referenced Files
F3353640: D3919.id12244.diff
Sat, Nov 23, 10:41 AM
F3353142: D3919.diff
Sat, Nov 23, 8:35 AM
F3347976: D3919.id12245.diff
Fri, Nov 22, 1:38 PM
F3347975: D3919.id12244.diff
Fri, Nov 22, 1:38 PM
F3347974: D3919.id12235.diff
Fri, Nov 22, 1:38 PM
F3347945: D3919.id.diff
Fri, Nov 22, 1:37 PM
F3347910: D3919.diff
Fri, Nov 22, 1:33 PM
Unknown Object (File)
Sat, Nov 9, 10:49 PM
View All Files
Subscribers
• abosh
• adrian
• karol
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMMdc7a4111fe5a: [native,lib,keyserver,web] [fix] [ENG-1083] fix comments that are too long
Summary

updates comments that are not 80 char length

https://linear.app/comm/issue/ENG-1083/eslint-rule-for-80-char-width-comments

Test Plan

run yarn eslint, you should get no errors, requesting ashoat here because comments are documentation which ashoat is a required reviewer on.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.May 4 2022, 11:18 AM
Herald added subscribers: • abosh, • karol, • adrian, tomek. · View Herald TranscriptMay 4 2022, 11:18 AM
• benschac added inline comments.May 4 2022, 11:20 AM
keyserver/src/socket/socket.js
477 ↗(On Diff #12235)

I deleted , accidently, will put it back.

lib/utils/fetch-json.js
132 ↗(On Diff #12235)

I removed the . to get to 80. Is that okay, @ashoat

• benschac added a parent revision: D3918: [root] [chore] [ENG-1083] update eslint config to enforce comment width to 80 characters.May 4 2022, 11:20 AM
• benschac edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B8787: Diff 12235.May 4 2022, 11:29 AM
• benschac requested review of this revision.May 4 2022, 11:29 AM
ashoat accepted this revision.May 4 2022, 11:44 AM
This revision is now accepted and ready to land.May 4 2022, 11:44 AM
• benschac updated this revision to Diff 12244.May 4 2022, 1:15 PM

add comment

This revision was landed with ongoing or failed builds.May 4 2022, 1:15 PM
Closed by commit rCOMMdc7a4111fe5a: [native,lib,keyserver,web] [fix] [ENG-1083] fix comments that are too long (authored by • benschac). · Explain Why
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMMdc7a4111fe5a: [native,lib,keyserver,web] [fix] [ENG-1083] fix comments that are too long.
Harbormaster completed remote builds in B8794: Diff 12244.May 4 2022, 1:19 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
socket/
7 lines
lib/
shared/
messages/
5 lines
utils/
10 lines
native/
chat/
10 lines
4 lines
navigation/
10 lines
types/
3 lines
utils/
3 lines
web/
chat/
10 lines

Diff 12245

View Options

keyserver/src/socket/socket.js

Loading...
View Options

lib/shared/messages/text-message-spec.js

Loading...
View Options

lib/utils/fetch-json.js

Loading...
View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

native/chat/chat-thread-list.react.js

Loading...
View Options

native/navigation/overlay-navigator.react.js

Loading...
View Options

native/types/themes.js

Loading...
View Options

native/utils/dev-hostname.js

Loading...
View Options

web/chat/chat-input-bar.react.js

Loading...