Use max-len rule. Code value in the config is default 80 and there's no way to turn it off. Hacking it with length of 420.
https://eslint.org/docs/rules/max-len
https://linear.app/comm/issue/ENG-1083/eslint-rule-for-80-char-width-comments
Differential D3918 Authored by • benschac on May 4 2022, 11:16 AM.
Details Summary Use max-len rule. Code value in the config is default 80 and there's no way to turn it off. Hacking it with length of 420. https://eslint.org/docs/rules/max-len https://linear.app/comm/issue/ENG-1083/eslint-rule-for-80-char-width-comments Test Plan you should see errors when running yarn eslint
Diff Detail
Event TimelineHerald added subscribers: • abosh, • karol, • adrian. · View Herald TranscriptMay 4 2022, 11:16 AM2022-05-04 11:16:50 (UTC-7) Harbormaster completed remote builds in B8786: Diff 12233.May 4 2022, 11:24 AM2022-05-04 11:24:51 (UTC-7) Comment Actions Discussed offline, this didn't actually do what @benschac thought it did, but he has another idea This revision now requires changes to proceed.May 4 2022, 11:44 AM2022-05-04 11:44:11 (UTC-7) • benschac edited the summary of this revision. (Show Details)May 4 2022, 11:52 AM2022-05-04 11:52:49 (UTC-7) Harbormaster completed remote builds in B8790: Diff 12238.May 4 2022, 11:55 AM2022-05-04 11:55:55 (UTC-7) Harbormaster completed remote builds in B8791: Diff 12239.May 4 2022, 12:01 PM2022-05-04 12:01:00 (UTC-7)
This revision now requires changes to proceed.May 4 2022, 12:28 PM2022-05-04 12:28:42 (UTC-7) Harbormaster completed remote builds in B8793: Diff 12242.May 4 2022, 1:14 PM2022-05-04 13:14:15 (UTC-7) ashoat added inline comments.
This revision is now accepted and ready to land.May 4 2022, 1:43 PM2022-05-04 13:43:26 (UTC-7) This revision was landed with ongoing or failed builds.May 4 2022, 1:52 PM2022-05-04 13:52:55 (UTC-7) Closed by commit rCOMM144cb1893c53: [root] [chore] [ENG-1083] update eslint config to enforce comment width to 80… (authored by • benschac). · Explain Why This revision was automatically updated to reflect the committed changes. Harbormaster completed remote builds in B8798: Diff 12253.May 4 2022, 1:56 PM2022-05-04 13:56:49 (UTC-7)
Revision Contents
Diff 12253 .eslintrc.json
|