Page MenuHomePhabricator
Differential D3926

[web] Remove unnecessary `form_footer` div and corresponding styles
ClosedPublic
Actions

Authored by atul on May 5 2022, 6:27 AM.
Tags
None
Referenced Files
F3392681: D3926.diff
Sat, Nov 30, 9:47 AM
Unknown Object (File)
Wed, Nov 27, 3:28 PM
Unknown Object (File)
Wed, Nov 27, 1:33 PM
Unknown Object (File)
Mon, Nov 11, 7:32 PM
Unknown Object (File)
Mon, Nov 11, 7:26 PM
Unknown Object (File)
Mon, Nov 11, 2:59 PM
Unknown Object (File)
Mon, Nov 11, 2:42 AM
Unknown Object (File)
Sat, Nov 9, 3:24 PM
View All Files
Subscribers
• abosh
• adrian
• karol

Details

Reviewers
ashoat
tomek
Commits
rCOMM8951a8faa85e: [web] Remove unnecessary `form_footer` div and corresponding styles
Summary

There's no need for this div. We can achieve the same thing with just the modal_form_error div.

Test Plan

Looks as expected:

Screen Shot 2022-05-05 at 9.26.22 AM.png (1×712 px, 76 KB)

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
web/
modals/
threads/
11 lines
4 lines

Diff 12273

View Options

web/modals/threads/thread-settings-modal.css

Loading...
View Options

web/modals/threads/thread-settings-modal.react.js

Loading...