[keyserver] Update report and upload URLs to use web.comm.app
ClosedPublic
Actions

Authored by ashoat on May 9 2022, 3:46 PM.

Details

Reviewers

atul
tomek

Commits

rCOMM13703c1d8d0a: [keyserver] Update report and upload URLs to use web.comm.app

Summary

Either should work. Now that web.comm.app is live, let's use that.

Also moving things to be fetched inside functions so that the app doesn't immediately crash if the config isn't present.

Depends on D3975

Test Plan

Confirmed that on prod our image URLs use squadcal.org, and that I can replace it with web.comm.app and the images still load

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 9 2022, 3:46 PM

Herald added subscribers: • abosh, • adrian. · View Herald TranscriptMay 9 2022, 3:46 PM

ashoat added a child revision: D3977: [keyserver] Make getSquadCalURLFacts return optional.May 9 2022, 3:47 PM

Harbormaster completed remote builds in B8945: Diff 12455.May 9 2022, 3:59 PM

ashoat requested review of this revision.May 9 2022, 3:59 PM

tomek accepted this revision.May 10 2022, 1:29 AM

This revision is now accepted and ready to land.May 10 2022, 1:29 AM

Closed by commit rCOMM13703c1d8d0a: [keyserver] Update report and upload URLs to use web.comm.app (authored by ashoat). · Explain WhyMay 10 2022, 6:01 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM13703c1d8d0a: [keyserver] Update report and upload URLs to use web.comm.app.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

creators/

report-creator.js

4 lines

fetchers/

upload-fetchers.js

5 lines

Diff 12499

View Options

keyserver/src/creators/report-creator.js