Page MenuHomePhabricator
Differential D4017

[web] Remove unused/unnecessary selectors from `thread-settings-delete-tab.css`
ClosedPublic
Actions

Authored by atul on May 12 2022, 10:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 5:12 AM
Unknown Object (File)
Fri, Nov 8, 9:48 AM
Unknown Object (File)
Fri, Nov 8, 9:12 AM
Unknown Object (File)
Fri, Nov 8, 7:39 AM
Unknown Object (File)
Fri, Nov 8, 5:14 AM
Unknown Object (File)
Fri, Nov 8, 4:10 AM
Unknown Object (File)
Sun, Nov 3, 1:29 PM
Unknown Object (File)
Nov 2 2024, 4:22 PM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
• jacek
tomek
• benschac
Commits
rCOMMc951c3f795c8: [web] Remove unused/unnecessary selectors from `thread-settings-delete-tab.css`
Summary
  1. Remove the textarea selector which isn't used
  2. Remove the "line" separating the notice from the instructions to delete

Depends on 4016

Test Plan

Before:

Screen Shot 2022-05-12 at 1.04.05 PM.png (792×716 px, 69 KB)

After:

Screen Shot 2022-05-12 at 1.08.47 PM.png (792×716 px, 69 KB)

Diff Detail

Repository
rCOMM Comm
Branch
landmay13 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.May 12 2022, 10:08 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 12 2022, 10:08 AM
atul edited the test plan for this revision. (Show Details)May 12 2022, 10:09 AM
Harbormaster completed remote builds in B9042: Diff 12585.May 12 2022, 10:13 AM
atul requested review of this revision.May 12 2022, 10:13 AM
atul edited the summary of this revision. (Show Details)May 12 2022, 10:13 AM
atul added a child revision: D4018: [web] Use `Input` component in `ThreadSettingsDeleteTab`.
• benschac accepted this revision.May 12 2022, 11:52 AM
This revision is now accepted and ready to land.May 12 2022, 11:52 AM
atul added 1 blocking reviewer(s): tomek.May 12 2022, 12:07 PM
This revision now requires review to proceed.May 12 2022, 12:07 PM
tomek accepted this revision.May 13 2022, 1:43 AM
This revision is now accepted and ready to land.May 13 2022, 1:43 AM
atul updated this revision to Diff 12671.May 13 2022, 11:57 AM

rebase before landing

This revision was landed with ongoing or failed builds.May 13 2022, 12:03 PM
Closed by commit rCOMMc951c3f795c8: [web] Remove unused/unnecessary selectors from `thread-settings-delete-tab.css` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMc951c3f795c8: [web] Remove unused/unnecessary selectors from `thread-settings-delete-tab.css`.
Harbormaster failed remote builds in B9109: Diff 12671!May 13 2022, 12:04 PM
Harbormaster completed remote builds in B9109: Diff 12671.May 13 2022, 12:11 PM

Revision Contents
Changeset List

Diff 12671

View Options

web/modals/threads/thread-settings-delete-tab.css

Loading...
View Options

web/modals/threads/thread-settings-delete-tab.react.js

Loading...