Following our convention to use glog, convert the std:cout messages to the LOG format with different log levels:
- INFO: For debug purposes,
- ERROR: For errors.
Related linear task: ENG-801
Details
Details
Start the service in INFO and ERROR-only modes.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- tunnelbroker-glog
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Following our convention to use glog
Could you remind me where this convention exists? I've searched the codebase and haven't found any usage of it. Also, do we need to install it somehow?
Comment Actions
The related task is ENG-801.
Before this task, we had a discussion in the Comm Dev Team chat and voted for glog because we already have it as a dependency from Folly.
Also, do we need to install it somehow?
No, because we already installed it as a dependency for Folly.
I've searched the codebase and haven't found any usage of it?
This is the first glog usage in our code (our Folly dependency uses it internally).
Comment Actions
This is the first glog usage in our code (our Folly dependency uses it internally).
Are we sure that we don't need to explicitly add glog as our dependency? @karol-bisztyga what's your opinion?
Comment Actions
This is a good point, I think since we explicitly use it ourselves and it's no longer just a folly dependency for us, then I think we should extract its installation into a separate script. I'm going to accept this as it looks ok to me but we should follow up about this.
Comment Actions
Given @karol-bisztyga's comment, it is critical that we create a Linear task for the follow-up before landing this diff