The NotificationsOption onSelect callback prop was being defined inline instead of being memoized with React.useCallback. This diff just fixes that.
Details
Details
Clicked through the NotificationsModal and things worked as expected.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
web/modals/threads/notifications/notifications-modal.react.js | ||
---|---|---|
44–45 ↗ | (On Diff #12752) | This was prettier |