Differential D4053
[yarn] Bump `flow-typed` to transitively bump `shelljs` Authored by atul on May 16 2022, 5:23 AM. Tags None Referenced Files
Details There was a @dependabot PR that bumped shelljs from 0.84 -> 0.85: https://github.com/CommE2E/comm/pull/158 that failed for some reason. Unfortunately the CI logs have long expired, but according to comment left by @ashoat the errors had something to do with flow. I tried bumping shelljs this time by removing and re-adding the flow-typed dependency from each package.json and it seems to work fine? CI
Diff Detail
Event Timeline
Comment Actions Ugh, there were no eslint/prettier issues on buildkite CI/Ubuntu machine I SSH'd into. Will see if there's a more "surgical" way to bump ShellJS without having all the transitive dependencies of flow-typed bumped as well. I think if I explicitly add shelljs to the root package.json as 0.85, then run yarn-deduplicate, then remove shelljs from the root package.json things should work... Comment Actions Quite a few eslint/prettier issues when yarn eslint --max-warnings=0 was run on Github CI machine: https://github.com/CommE2E/comm/runs/6459657382?check_suite_focus=true Issues that did not surface on Buildkite CI or Ubuntu machine I SSH'd into:  Comment Actions "more surgical" approach to hopefully avoid the strange eslint/prettier issues edit: does not fail yarn eslint --max-warnings=0 where it did previously (local machine) | ||||||||||||||||||||||||||||||||||