Page MenuHomePhabricator
Differential D4089

[services] Backup - Add Attachment Reactor - terminate callback
AbandonedPublic
Actions

Authored by • karol on May 19 2022, 3:06 AM.
Tags
None
Referenced Files
F3562954: D4089.id13056.diff
Fri, Dec 27, 11:06 AM
F3562801: D4089.diff
Fri, Dec 27, 11:02 AM
F3562635: D4089.id12933.diff
Fri, Dec 27, 10:58 AM
F3550907: D4089.diff
Thu, Dec 26, 7:03 PM
Unknown Object (File)
Nov 14 2024, 7:07 AM
Unknown Object (File)
Nov 5 2024, 2:54 PM
Unknown Object (File)
Oct 23 2024, 12:49 PM
Unknown Object (File)
Oct 23 2024, 11:37 AM
View All Files
Subscribers
• abosh
• adrian
ashoat
atul
tomek

Details

Reviewers
tomek
ashoat
Summary

Depends on D4112

Adding the terminate callback to the add attachment reactor. It puts the attachment data in the database.

Test Plan

The backup service can be built successfully.

For the full test plan of this functionality that has been broken into multiple diffs, please see D4090.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• karol created this revision.May 19 2022, 3:06 AM
Herald added subscribers: • abosh, atul, • adrian and 2 others. · View Herald TranscriptMay 19 2022, 3:06 AM
• karol edited the summary of this revision. (Show Details)May 19 2022, 4:17 AM
• karol edited the test plan for this revision. (Show Details)
• karol added a reviewer: tomek.
• karol added a parent revision: D4088: [services] Backup - Add Attachment Reactor - store in database.
• karol added a child revision: D4090: [services] Backup - Use Add Attachment Reactor.May 19 2022, 4:20 AM
Harbormaster completed remote builds in B9332: Diff 12933.May 19 2022, 4:24 AM
• karol requested review of this revision.May 19 2022, 4:24 AM
• karol planned changes to this revision.May 24 2022, 3:02 AM
• karol edited the summary of this revision. (Show Details)May 24 2022, 3:05 AM
• karol added a parent revision: D4112: [services] Backup - Add Attachment Reactor - read request.
• karol updated this revision to Diff 13056.May 24 2022, 3:08 AM
• karol edited the summary of this revision. (Show Details)

update

• karol edited the summary of this revision. (Show Details)May 24 2022, 3:10 AM
Harbormaster completed remote builds in B9430: Diff 13056.May 24 2022, 3:31 AM
ashoat requested changes to this revision.May 24 2022, 12:16 PM

As discussed in the proto diff, this API should not be in the backup service

This revision now requires changes to proceed.May 24 2022, 12:16 PM
• karol abandoned this revision.May 26 2022, 3:04 AM

Revision Contents
Changeset List

PathSize
services/
backup/
src/
Reactors/
server/
17 lines

Diff 12933

View Options

services/backup/src/Reactors/server/AddAttachmentReactor.cpp

Loading...